Page MenuHomePhorge
Feed Advanced Search

Feb 16 2021

machniak committed rKb3cb2a9bad2b: Meet: Fix javascript error when leaving a room (authored by machniak).
Meet: Fix javascript error when leaving a room
Feb 16 2021, 3:54 PM
machniak closed D2263: Meet: Fix javascript error when leaving a room.
Feb 16 2021, 3:54 PM
machniak added a comment to D2275: improve room icons.

Maybe we should apply it anyway, and revisit again now that we have even more buttons (hand and channels) in the toolbar.

Feb 16 2021, 3:27 PM
machniak added a comment to D2275: improve room icons.

As for the chat icon and status icons change I'm ok with this. But I'm not sure about the rest.

Feb 16 2021, 3:22 PM
machniak added a comment to D2269: hide menubar when in rooms.

The idea was to hide the menu/footer inside the room, i.e. after joining in, but room setup screen should have the menu as usual. I also don't like making component/page specific exceptions in the Menu widget. I would probably do it with css. Also the code added in Room.vue asks for some deduplication, i.e. we need a method on the $root component that could be re-used as we have the same code in at least two places now. Not to mention that in this state some browser tests will fail (but I didn't check yet).

Feb 16 2021, 3:17 PM
machniak requested review of D2263: Meet: Fix javascript error when leaving a room.
Feb 16 2021, 1:36 PM

Feb 15 2021

machniak committed rKe808cfecc263: Fix js error after merge(s) (authored by machniak).
Fix js error after merge(s)
Feb 15 2021, 1:28 PM

Feb 12 2021

machniak updated the diff for D2257: Meet: A room config option to force all to join as subscribers.
  • Add forgotten component
Feb 12 2021, 2:36 PM
machniak requested review of D2257: Meet: A room config option to force all to join as subscribers.
Feb 12 2021, 2:34 PM
machniak requested review of D2251: Meet: Mute microphone with M key.
Feb 12 2021, 1:03 PM
machniak updated the summary of D2245: Meet: Language interpreters.
Feb 12 2021, 12:05 PM
machniak requested review of D2245: Meet: Language interpreters.
Feb 12 2021, 11:56 AM

Feb 8 2021

machniak requested review of D2233: Meet: Q&A queue (raise hand feature).
Feb 8 2021, 12:55 PM

Feb 5 2021

machniak requested review of D2227: Meet: Fix replaceTrack() bug.
Feb 5 2021, 2:24 PM

Feb 4 2021

machniak added inline comments to D1924: Restoring a user/domain.
Feb 4 2021, 2:41 PM
machniak updated the diff for D2068: OpenVidu: Store join request identifier in localStorage.

Rebase

Feb 4 2021, 10:11 AM
machniak committed rKbb7c64d867f6: De-deuplicate some tests code (authored by machniak).
De-deuplicate some tests code
Feb 4 2021, 10:05 AM
machniak committed rKe4a2e7060d30: Meet: Improved error handling (authored by machniak).
Meet: Improved error handling
Feb 4 2021, 8:30 AM
machniak closed D2203: Meet: Improved error handling.
Feb 4 2021, 8:30 AM
machniak committed rKaa1418383a70: Meet: Fix chat scrolling (authored by machniak).
Meet: Fix chat scrolling
Feb 4 2021, 8:30 AM
machniak closed D2209: Meet: Fix chat scrolling.
Feb 4 2021, 8:30 AM

Feb 3 2021

machniak added inline comments to D2221: On promotion to publisher display the media setup dialog.
Feb 3 2021, 4:18 PM
machniak updated the diff for D2203: Meet: Improved error handling.
  • Remove redundant condition
Feb 3 2021, 3:21 PM
machniak requested review of D2221: On promotion to publisher display the media setup dialog.
Feb 3 2021, 3:16 PM
machniak accepted D2215: If the refund amount is positive, we need to turn that frown upside down.
Feb 3 2021, 2:55 PM
machniak planned changes to D2203: Meet: Improved error handling.

I'll review this again regarding 422 handling.

Feb 3 2021, 2:42 PM
machniak added inline comments to D2203: Meet: Improved error handling.
Feb 3 2021, 2:04 PM

Feb 2 2021

machniak requested changes to D1954: ux cleanup. move 'delete account' button to the top.

A couple of browser tests need to be modified in tests/Browser/UsersTest.php

Feb 2 2021, 1:49 PM
machniak requested review of D2209: Meet: Fix chat scrolling.
Feb 2 2021, 11:51 AM
machniak requested review of D2203: Meet: Improved error handling.
Feb 2 2021, 11:49 AM

Feb 1 2021

machniak added a comment to D2137: add charge period to transactions.

And of course some tests will be needed.

Feb 1 2021, 12:45 PM
machniak requested changes to D2137: add charge period to transactions.
Feb 1 2021, 12:34 PM
machniak committed rKe4bb4f88f6e1: Fix type hint (authored by machniak).
Fix type hint
Feb 1 2021, 11:47 AM
machniak committed rKe968a6ccf02d: Improve handling of screen-sharing connection tokens (authored by machniak).
Improve handling of screen-sharing connection tokens
Feb 1 2021, 11:47 AM
machniak committed rK345ce72e058c: OpenVidu: Moderators (authored by machniak).
OpenVidu: Moderators
Feb 1 2021, 11:47 AM
machniak committed rK8ca91d53f4fc: Fix connection role propagation to new connections (authored by machniak).
Fix connection role propagation to new connections
Feb 1 2021, 11:47 AM
machniak committed rKd80c6c0ebeeb: Add tests for media setup dialog (authored by machniak).
Add tests for media setup dialog
Feb 1 2021, 11:47 AM
machniak committed rK610cf13921c4: Fix test regressions (authored by machniak).
Fix test regressions
Feb 1 2021, 11:47 AM
machniak committed rK4088e8d694b6: Media setup dialog (authored by machniak).
Media setup dialog
Feb 1 2021, 11:47 AM
machniak committed rK918f5bfcbc2f: Test updateConnection endpoint (authored by machniak).
Test updateConnection endpoint
Feb 1 2021, 11:47 AM
machniak committed rKbab58fac8f70: More tests (authored by machniak).
More tests
Feb 1 2021, 11:47 AM
machniak committed rK6eb144d54850: Simplify resize() calls (authored by machniak).
Simplify resize() calls
Feb 1 2021, 11:47 AM
machniak committed rK9b82d3a28500: Cleanup (authored by machniak).
Cleanup
Feb 1 2021, 11:47 AM
machniak committed rK660032eb2a6f: Publisher-to-subscriber and vice-versa (authored by machniak).
Publisher-to-subscriber and vice-versa
Feb 1 2021, 11:47 AM
machniak committed rK06226e33da8b: Tests: Use the menu when changing nickname (authored by machniak).
Tests: Use the menu when changing nickname
Feb 1 2021, 11:47 AM
machniak committed rK1c61c1e36f17: Fix regressions (authored by machniak).
Fix regressions
Feb 1 2021, 11:47 AM
machniak committed rKb7baff245328: Use proper event system to handle audio/video status indication Add "Nickname"… (authored by machniak).
Use proper event system to handle audio/video status indication Add "Nickname"…
Feb 1 2021, 11:47 AM
machniak committed rKd0bfc17e4ba5: Improve menu layout (authored by machniak).
Improve menu layout
Feb 1 2021, 11:47 AM
machniak committed rKff81deb8fecd: Publisher-to-subscriber and vice-versa (authored by machniak).
Publisher-to-subscriber and vice-versa
Feb 1 2021, 11:47 AM
machniak updated the diff for D2197: Improve handling of screen-sharing connection tokens.
  • Fix type hint
Feb 1 2021, 11:32 AM
machniak requested review of D2197: Improve handling of screen-sharing connection tokens.
Feb 1 2021, 11:21 AM
machniak committed rRPK87fbaea6960a: PHP8 compatibility fixes (authored by machniak).
PHP8 compatibility fixes
Feb 1 2021, 8:31 AM
machniak closed D2185: PHP8 compatibility fixes.
Feb 1 2021, 8:30 AM · Roundcube Kolab Plugins
machniak committed rRPKfba24494dd26: Elastic dark mode (authored by machniak).
Elastic dark mode
Feb 1 2021, 8:25 AM
machniak closed D2179: Elastic dark mode.
Feb 1 2021, 8:25 AM

Jan 29 2021

machniak requested review of D2191: OpenVidu: Moderators.
Jan 29 2021, 10:43 AM

Jan 28 2021

machniak added a reviewer for D2185: PHP8 compatibility fixes: Roundcube Kolab Plugins Developers.
Jan 28 2021, 4:14 PM · Roundcube Kolab Plugins
machniak requested review of D2185: PHP8 compatibility fixes.
Jan 28 2021, 4:14 PM · Roundcube Kolab Plugins
machniak added a reviewer for D2179: Elastic dark mode: Roundcube Kolab Plugins Developers.
Jan 28 2021, 4:01 PM
machniak updated the diff for D2179: Elastic dark mode.

-fix

Jan 28 2021, 3:59 PM
machniak requested review of D2179: Elastic dark mode.
Jan 28 2021, 3:56 PM
machniak committed rRPK2bee26214028: Merge branch 'dev/dark-mode' of ssh://git.kolab.org/diffusion/RPK into dev/dark… (authored by machniak).
Merge branch 'dev/dark-mode' of ssh://git.kolab.org/diffusion/RPK into dev/dark…
Jan 28 2021, 3:52 PM
machniak committed rRPKebf36c0a36ea: Fix compat. with lessjs v4 (authored by machniak).
Fix compat. with lessjs v4
Jan 28 2021, 3:51 PM
machniak committed rRPK8863dc521940: Fix compatibility with Roundcube 1.4 (authored by machniak).
Fix compatibility with Roundcube 1.4
Jan 28 2021, 3:51 PM
machniak committed rRPK3e6d66ac1102: Fix compat. with less.js v4 (authored by machniak).
Fix compat. with less.js v4
Jan 28 2021, 3:51 PM
machniak committed rRPKc45cb992f440: Elastic dark mode (authored by machniak).
Elastic dark mode
Jan 28 2021, 3:51 PM
machniak added a member for Autoconf Developers: mollekopf.
Jan 28 2021, 3:49 PM
machniak accepted D2173: Support forcing a subscription state.

The disabled attribute value could be boolean not string, but it will work either way.

Jan 28 2021, 10:30 AM
machniak requested changes to D2173: Support forcing a subscription state.
Jan 28 2021, 9:46 AM

Jan 27 2021

machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
  • Media setup dialog
  • Fix test regressions
  • Add tests for media setup dialog
  • Fix connection role propagation to new connections
Jan 27 2021, 12:19 PM
machniak updated the diff for D2068: OpenVidu: Store join request identifier in localStorage.
  • Rebase
Jan 27 2021, 9:20 AM

Jan 26 2021

machniak updated the diff for D2167: Meet/Beta - private vs public beta.
  • Add missing migration file
Jan 26 2021, 5:13 PM
machniak requested review of D2167: Meet/Beta - private vs public beta.
Jan 26 2021, 4:53 PM
machniak requested review of D2167: Meet/Beta - private vs public beta.
Jan 26 2021, 4:53 PM
machniak planned changes to D2149: Publisher-to-subscriber and vice-versa.

I've found one issue. The role change is not propagated to new connections. Scenario:

  1. User1 joins as a subscriber
  2. Moderator promotes him to a publisher
  3. User2 joins and sees a UI issue, because the User1 tail is a subscriber-like tile, and there's a video element of User1 "out of the matrix".
Jan 26 2021, 1:15 PM
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Add tests for media setup dialog
Jan 26 2021, 12:31 PM
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Fix test regressions
Jan 26 2021, 11:53 AM
machniak accepted D2143: Remove folder typedata in-memory cache.
Jan 26 2021, 11:47 AM · Roundcube Kolab Plugins
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Media setup dialog
Jan 26 2021, 11:34 AM

Jan 22 2021

machniak committed rRPKf5678b7c5bf1: PHP8 fixes (authored by machniak).
PHP8 fixes
Jan 22 2021, 6:23 PM
machniak added a comment to D2143: Remove folder typedata in-memory cache.

If you think that this internal cache is not really needed then go this way and remove use of self::$typedata. In rare cases when we list folders for all folder types separately in a single request, we'll end up with several requests to the Roundcube imap cache, instead of one. I'm afraid that we might call folder_typedata() or folder_type() methods quite a lot, but I didn't check that, so I'm not sure.

Jan 22 2021, 1:55 PM · Roundcube Kolab Plugins
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
Jan 22 2021, 11:00 AM

Jan 21 2021

machniak requested review of D2149: Publisher-to-subscriber and vice-versa.
Jan 21 2021, 3:21 PM
machniak added a comment to D2143: Remove folder typedata in-memory cache.

How about we call self::folders_typedata($prefix); to populate the cache, but then user folder_type() anyways to fetch missing entries (it still uses the cache if available)?

Jan 21 2021, 12:09 PM · Roundcube Kolab Plugins
machniak added a comment to D2143: Remove folder typedata in-memory cache.

With this change METADATA for every folder will be asked separately. This definitely will have performance implications. Maybe a better approach would be to add a method to reset kolab_storage::$typedata (and other cache-like data if needed). And call that method from syncroton's kolab_sync::sleep() or kolab_sync_backend_folder::hasHierarchyChanges().

Jan 21 2021, 11:41 AM · Roundcube Kolab Plugins

Jan 19 2021

machniak committed rK768848eaa55c: [MEET]: Generic implementation of Roles/Permissions (authored by machniak).
[MEET]: Generic implementation of Roles/Permissions
Jan 19 2021, 4:04 PM
machniak closed D2098: [MEET]: Generic implementation of Roles/Permissions.
Jan 19 2021, 4:04 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Fix typo
Jan 19 2021, 12:41 PM
machniak removed a member for Roundcube Kolab Plugins Developers: Adityab.
Jan 19 2021, 12:05 PM
machniak added a member for Roundcube Kolab Plugins Developers: mollekopf.
Jan 19 2021, 12:05 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Improve constants handling
  • Add unique key on openvidu_connections.session_id
  • Fix: session_id should be indexed but not unique
  • Remove redundant where clause
Jan 19 2021, 11:26 AM
machniak committed rK14d3d27bddef: Prevent double-submission of payments form (authored by machniak).
Prevent double-submission of payments form
Jan 19 2021, 11:12 AM
machniak closed D2104: Prevent double-submission of payments form.
Jan 19 2021, 11:12 AM
machniak committed rKab1b623aa93c: Update npm dependencies (authored by machniak).
Update npm dependencies
Jan 19 2021, 11:12 AM
machniak closed D2116: Update npm dependencies.
Jan 19 2021, 11:11 AM
machniak accepted D2056: Bump collectionChanges even if we failed to retrieve the entry..
Jan 19 2021, 11:07 AM
machniak accepted D2062: Compress pendingdata.
Jan 19 2021, 11:06 AM
machniak accepted D2092: Do not ignore INBOX for the displayed folder hierarchy.
Jan 19 2021, 11:04 AM
machniak added a comment to D2131: Avoid Sync unnecessary FolderSync interaction.

Wouldn't global STATUS_FOLDER_HIERARCHY_HAS_CHANGED status be more appropriate? Or this does not work with Outlook?

Jan 19 2021, 10:44 AM
machniak added a comment to D2128: A synckey that is not matching the server sync key is invalid..

This code is not supposed to be used by Kolab backend. We're using kolab_sync_backend_state::validate().

Jan 19 2021, 10:28 AM