States can be:
- 0 => not subscribed
- 1 => subscribed, no alarms
- 2 => subscribed with alarms
The primary usecase is to disallow unsubscribing folders that Outlook
does not allow to be unsubscribed.
Details
Details
- Reviewers
machniak - Group Reviewers
Roundcube Kolab Plugins Developers - Commits
- rRPK7203e494840f: Support forcing a subscription state
Diff Detail
Diff Detail
- Repository
- rRPK roundcubemail-plugins-kolab
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Regarding activesync_init_subscriptions; I did not address this yet. For the initial usecase this is good enough, and in a future patch I suppose we could read the same setting in synchroton and initalize the subscription accordingly.
| plugins/kolab_activesync/kolab_activesync_ui.php | ||
|---|---|---|
| 104 | key_exists is an alias for array_key_exists and I prefer to not use aliases. | |
| 236 | You could just set disabled=null for when it's not true, and make the whole code shorter. No need for array_merge() and $extra_attributes. And checkboxes could be created out of the loop as before. | |
Comment Actions
The disabled attribute value could be boolean not string, but it will work either way.