Page MenuHomePhorge

Support forcing a subscription state
ClosedPublic

Authored by mollekopf on Jan 27 2021, 9:53 AM.
Tags
None
Referenced Files
F11595543: D2173.id6055.diff
Fri, Mar 29, 9:57 AM
F11590275: D2173.id6052.diff
Fri, Mar 29, 2:07 AM
Unknown Object (File)
Sat, Mar 16, 9:21 PM
Unknown Object (File)
Feb 24 2024, 5:32 PM
Unknown Object (File)
Feb 23 2024, 7:16 PM
Unknown Object (File)
Feb 10 2024, 8:37 AM
Unknown Object (File)
Feb 8 2024, 3:40 PM
Unknown Object (File)
Jan 30 2024, 4:45 PM
Subscribers
None

Details

Summary

States can be:

  • 0 => not subscribed
  • 1 => subscribed, no alarms
  • 2 => subscribed with alarms

The primary usecase is to disallow unsubscribing folders that Outlook
does not allow to be unsubscribed.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32935
Build 12826: arc lint + arc unit

Event Timeline

mollekopf created this revision.

Regarding activesync_init_subscriptions; I did not address this yet. For the initial usecase this is good enough, and in a future patch I suppose we could read the same setting in synchroton and initalize the subscription accordingly.

machniak added inline comments.
plugins/kolab_activesync/kolab_activesync_ui.php
104

key_exists is an alias for array_key_exists and I prefer to not use aliases.

239

You could just set disabled=null for when it's not true, and make the whole code shorter. No need for array_merge() and $extra_attributes. And checkboxes could be created out of the loop as before.

This revision now requires changes to proceed.Jan 28 2021, 9:46 AM
mollekopf marked an inline comment as done.

Addressed comments

The disabled attribute value could be boolean not string, but it will work either way.

This revision is now accepted and ready to land.Jan 28 2021, 10:30 AM
This revision was automatically updated to reflect the committed changes.