Page MenuHomekolab.org

Support forcing a subscription state
ClosedPublic

Authored by mollekopf on Jan 27 2021, 9:53 AM.

Details

Summary

States can be:

  • 0 => not subscribed
  • 1 => subscribed, no alarms
  • 2 => subscribed with alarms

The primary usecase is to disallow unsubscribing folders that Outlook
does not allow to be unsubscribed.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32929
Build 12820: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Jan 27 2021, 9:53 AM
mollekopf created this revision.

Regarding activesync_init_subscriptions; I did not address this yet. For the initial usecase this is good enough, and in a future patch I suppose we could read the same setting in synchroton and initalize the subscription accordingly.

mollekopf updated this revision to Diff 6055.Jan 27 2021, 9:59 AM

Updated description

machniak requested changes to this revision.Jan 28 2021, 9:46 AM
machniak added inline comments.
plugins/kolab_activesync/kolab_activesync_ui.php
104

key_exists is an alias for array_key_exists and I prefer to not use aliases.

239–242

You could just set disabled=null for when it's not true, and make the whole code shorter. No need for array_merge() and $extra_attributes. And checkboxes could be created out of the loop as before.

This revision now requires changes to proceed.Jan 28 2021, 9:46 AM
mollekopf updated this revision to Diff 6067.Jan 28 2021, 10:23 AM
mollekopf marked an inline comment as done.

Addressed comments

mollekopf marked an inline comment as done.Jan 28 2021, 10:24 AM
machniak accepted this revision.Jan 28 2021, 10:30 AM

The disabled attribute value could be boolean not string, but it will work either way.

This revision is now accepted and ready to land.Jan 28 2021, 10:30 AM
This revision was automatically updated to reflect the committed changes.