Page MenuHomekolab.org

ux cleanup. move 'delete account' button to the top
Needs RevisionPublic

Authored by bohlender on Dec 17 2020, 9:47 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Summary

Diff Detail

Repository
rK kolab
Branch
deleteButton
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32137
Build 12313: arc lint + arc unit

Event Timeline

bohlender requested review of this revision.Dec 17 2020, 9:47 AM
bohlender created this revision.
bohlender edited the summary of this revision. (Show Details)Dec 17 2020, 9:49 AM
bohlender added a reviewer: Restricted Project.
bohlender added a subscriber: Restricted Project.

I'm not sure. Is it an exception for this one page or this is a general rule that delete button should be on top? E.g. regarding https://bifrost.kolabsystems.com/T375653 What if the button will be in bottom-right corner?

I'm not sure.

The main goal was to move it away from the submit button.
It should neither be on the same line as the submit button, nor in the form to make it clear that this is not an part of the actual form.

It being on the top is in line with the top "add" button being on the top of lists.

What if the button will be in bottom-right corner?

I like it a bit less but it would work on desktop. Less so on mobile UI. There the buttons would be close again.

Is it an exception for this one page or this is a general rule that delete button should be on top? E.g. regarding https://bifrost.kolabsystems.com/T375653

It is intended as a general pattern that would work for user accounts, user domains and so on.

vanmeeuwen requested changes to this revision.Dec 23 2020, 11:40 AM
vanmeeuwen added a subscriber: vanmeeuwen.

Can we, in this case, ensure that it does get applied across the board consistently?

This revision now requires changes to proceed.Dec 23 2020, 11:40 AM