Page MenuHomekolab.org

ux cleanup. move 'delete account' button to the top
ClosedPublic

Authored by bohlender on Dec 17 2020, 9:47 AM.

Details

Diff Detail

Repository
rK kolab
Branch
arcpatch-D1954
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33148
Build 12961: arc lint + arc unit

Event Timeline

bohlender requested review of this revision.Dec 17 2020, 9:47 AM
bohlender created this revision.
bohlender edited the summary of this revision. (Show Details)Dec 17 2020, 9:49 AM
bohlender added a reviewer: Restricted Project.
bohlender added a subscriber: Restricted Project.

I'm not sure. Is it an exception for this one page or this is a general rule that delete button should be on top? E.g. regarding https://bifrost.kolabsystems.com/T375653 What if the button will be in bottom-right corner?

I'm not sure.

The main goal was to move it away from the submit button.
It should neither be on the same line as the submit button, nor in the form to make it clear that this is not an part of the actual form.

It being on the top is in line with the top "add" button being on the top of lists.

What if the button will be in bottom-right corner?

I like it a bit less but it would work on desktop. Less so on mobile UI. There the buttons would be close again.

Is it an exception for this one page or this is a general rule that delete button should be on top? E.g. regarding https://bifrost.kolabsystems.com/T375653

It is intended as a general pattern that would work for user accounts, user domains and so on.

vanmeeuwen requested changes to this revision.Dec 23 2020, 11:40 AM
vanmeeuwen added a subscriber: vanmeeuwen.

Can we, in this case, ensure that it does get applied across the board consistently?

This revision now requires changes to proceed.Dec 23 2020, 11:40 AM
bohlender updated this revision to Diff 6016.Jan 26 2021, 3:48 PM
  • delete users from Info instead of list
bohlender updated this revision to Diff 6022.Jan 26 2021, 3:50 PM
  • remove some whitespace
machniak requested changes to this revision.Feb 2 2021, 1:49 PM

A couple of browser tests need to be modified in tests/Browser/UsersTest.php

src/resources/vue/User/Info.vue
417

.modal('hide') is redundant here.

src/resources/vue/User/List.vue
28

Remove 'colspan' here.

This revision now requires changes to proceed.Feb 2 2021, 1:49 PM
bohlender updated this revision to Diff 6265.Feb 11 2021, 5:27 PM
  • remove obsolte colspan and modal('hide')
bohlender marked 2 inline comments as done.Feb 11 2021, 5:28 PM
machniak requested changes to this revision.Apr 8 2021, 12:45 PM

Browser tests need to be updated.

This revision now requires changes to proceed.Apr 8 2021, 12:45 PM
machniak updated this revision to Diff 6919.Mon, Apr 19, 1:00 PM
  • Fix tests
  • Small color improvements
mollekopf accepted this revision.Tue, Apr 20, 3:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Apr 21, 11:39 AM
This revision was automatically updated to reflect the committed changes.