Page MenuHomePhorge

ux cleanup. move 'delete account' button to the top
ClosedPublic

Authored by bohlender on Dec 17 2020, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 2:41 PM
Unknown Object (File)
Mon, Mar 11, 5:56 AM
Unknown Object (File)
Feb 14 2024, 8:43 AM
Unknown Object (File)
Feb 11 2024, 3:35 PM
Unknown Object (File)
Feb 1 2024, 6:25 PM
Unknown Object (File)
Jan 29 2024, 7:45 PM
Unknown Object (File)
Jan 29 2024, 7:45 PM
Unknown Object (File)
Jan 25 2024, 4:00 AM
Subscribers
Restricted Project

Details

Diff Detail

Repository
rK kolab
Branch
deleteButton
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32899
Build 12796: arc lint + arc unit

Event Timeline

bohlender created this revision.
bohlender added a reviewer: Restricted Project.
bohlender added a subscriber: Restricted Project.

I'm not sure. Is it an exception for this one page or this is a general rule that delete button should be on top? E.g. regarding https://bifrost.kolabsystems.com/T375653 What if the button will be in bottom-right corner?

I'm not sure.

The main goal was to move it away from the submit button.
It should neither be on the same line as the submit button, nor in the form to make it clear that this is not an part of the actual form.

It being on the top is in line with the top "add" button being on the top of lists.

What if the button will be in bottom-right corner?

I like it a bit less but it would work on desktop. Less so on mobile UI. There the buttons would be close again.

Is it an exception for this one page or this is a general rule that delete button should be on top? E.g. regarding https://bifrost.kolabsystems.com/T375653

It is intended as a general pattern that would work for user accounts, user domains and so on.

vanmeeuwen subscribed.

Can we, in this case, ensure that it does get applied across the board consistently?

This revision now requires changes to proceed.Dec 23 2020, 11:40 AM
  • delete users from Info instead of list
machniak requested changes to this revision.Feb 2 2021, 1:49 PM

A couple of browser tests need to be modified in tests/Browser/UsersTest.php

src/resources/vue/User/Info.vue
417

.modal('hide') is redundant here.

src/resources/vue/User/List.vue
28

Remove 'colspan' here.

This revision now requires changes to proceed.Feb 2 2021, 1:49 PM
  • remove obsolte colspan and modal('hide')

Browser tests need to be updated.

This revision now requires changes to proceed.Apr 8 2021, 12:45 PM
  • Fix tests
  • Small color improvements
This revision was not accepted when it landed; it landed in state Needs Review.Apr 21 2021, 11:39 AM
This revision was automatically updated to reflect the committed changes.