- Group Reviewers
The idea was to hide the menu/footer inside the room, i.e. after joining in, but room setup screen should have the menu as usual. I also don't like making component/page specific exceptions in the Menu widget. I would probably do it with css. Also the code added in Room.vue asks for some deduplication, i.e. we need a method on the $root component that could be re-used as we have the same code in at least two places now. Not to mention that in this state some browser tests will fail (but I didn't check yet).
I think I could give it a try, it's not a big task.
More like it. I would probably do this with css.
Isn't that also one component knowing about the other and manipulating it ?
Yes, but it is a page component not a widget. So, better, imo.