Page MenuHomekolab.org

hide menubar when in rooms
AbandonedPublic

Authored by bohlender on Feb 16 2021, 1:49 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project

Diff Detail

Repository
rK kolab
Branch
menubargone
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33232
Build 13018: arc lint + arc unit

Event Timeline

bohlender requested review of this revision.Feb 16 2021, 1:49 PM
bohlender created this revision.
bohlender added a reviewer: Restricted Project.Feb 16 2021, 2:07 PM

The idea was to hide the menu/footer inside the room, i.e. after joining in, but room setup screen should have the menu as usual. I also don't like making component/page specific exceptions in the Menu widget. I would probably do it with css. Also the code added in Room.vue asks for some deduplication, i.e. we need a method on the $root component that could be re-used as we have the same code in at least two places now. Not to mention that in this state some browser tests will fail (but I didn't check yet).

I think I could give it a try, it's not a big task.

@machniak
Is this what you want instead: https://git.kolab.org/D2281 ?
Isn't that also one component knowing about the other and manipulating it ?

Is this what you want instead: https://git.kolab.org/D2281 ?

More like it. I would probably do this with css.

Isn't that also one component knowing about the other and manipulating it ?

Yes, but it is a page component not a widget. So, better, imo.

vanmeeuwen abandoned this revision.Feb 19 2021, 1:25 PM