Page MenuHomekolab.org

Do not ignore INBOX for the displayed folder hierarchy
ClosedPublic

Authored by mollekopf on Wed, Jan 13, 7:05 PM.

Details

Summary

Previously INBOX.Archive and Archive were indistinguishable.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf created this revision.Wed, Jan 13, 7:05 PM
mollekopf requested review of this revision.Wed, Jan 13, 7:05 PM

FWIW, this code was just like this from the beginning, so I don't know if there ever was a valid usecase for it.
Can't think of one though.

I'm not sure I like this. While fixing the issue you also changed how the list will look like. I.e. flat list instead of a tree-like list. If we do this anyway we should do the same in kolab_delegation plugin.

mollekopf updated this revision to Diff 5863.Mon, Jan 18, 2:28 PM
mollekopf retitled this revision from Do not truncate the prefix in the activesync UI to Do not ignore INBOX for the displayed folder hierarchy.

Instead of not showing a tree at all, show it for INBOX as well.

This solves the original concern, while keeping the hierarchy intact.
This is also relevant because the previous patch did not work with localized special folder names (such as "Posteingang" for INBOX).

I applied the same change for delegation as well.

FWIW, I assume the original code meant to make the case prettier where all folders are below inbox. I think for the affected UI's it shouldn't be a big deal, and avoids the confusing situation we can have right now.

machniak accepted this revision.Tue, Jan 19, 11:04 AM
This revision is now accepted and ready to land.Tue, Jan 19, 11:04 AM
This revision was automatically updated to reflect the committed changes.