Page MenuHomekolab.org

[MEET]: Generic implementation of Roles/Permissions
ClosedPublic

Authored by machniak on Thu, Jan 14, 2:04 PM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK768848eaa55c: [MEET]: Generic implementation of Roles/Permissions
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Thu, Jan 14, 2:04 PM
machniak created this revision.
machniak updated this revision to Diff 5788.Thu, Jan 14, 2:24 PM
  • Improve constants handling
vanmeeuwen added inline comments.
src/database/migrations/2021_01_13_120000_create_openvidu_connections_table.php
32

TODO for Jeroen: examine which indexes to use.

machniak updated this revision to Diff 5830.Mon, Jan 18, 9:07 AM
  • Add unique key on openvidu_connections.session_id
machniak updated this revision to Diff 5836.Mon, Jan 18, 10:15 AM
  • Fix: session_id should be indexed but not unique
vanmeeuwen requested changes to this revision.Tue, Jan 19, 10:57 AM
vanmeeuwen added inline comments.
src/database/migrations/2021_01_13_120000_create_openvidu_connections_table.php
32

there should be an additional index on ['room_id', 'session_id'] because of Room.php 364

This revision now requires changes to proceed.Tue, Jan 19, 10:57 AM
machniak updated this revision to Diff 5887.Tue, Jan 19, 11:26 AM
  • Improve constants handling
  • Add unique key on openvidu_connections.session_id
  • Fix: session_id should be indexed but not unique
  • Remove redundant where clause
machniak updated this revision to Diff 5899.Tue, Jan 19, 12:41 PM
  • Fix typo
vanmeeuwen accepted this revision.Tue, Jan 19, 3:29 PM
This revision is now accepted and ready to land.Tue, Jan 19, 3:29 PM
This revision was automatically updated to reflect the committed changes.