Page MenuHomePhorge

[MEET]: Generic implementation of Roles/Permissions
ClosedPublic

Authored by machniak on Jan 14 2021, 2:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 5:25 AM
Unknown Object (File)
Thu, Feb 29, 4:58 PM
Unknown Object (File)
Feb 26 2024, 7:34 AM
Unknown Object (File)
Feb 14 2024, 11:09 PM
Unknown Object (File)
Feb 9 2024, 11:33 AM
Unknown Object (File)
Jan 31 2024, 1:23 PM
Unknown Object (File)
Jan 19 2024, 9:32 PM
Unknown Object (File)
Jan 19 2024, 1:06 PM
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK768848eaa55c: [MEET]: Generic implementation of Roles/Permissions
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/openvidu-roles
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32701
Build 12655: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Improve constants handling
vanmeeuwen added inline comments.
src/database/migrations/2021_01_13_120000_create_openvidu_connections_table.php
32

TODO for Jeroen: examine which indexes to use.

  • Add unique key on openvidu_connections.session_id
  • Fix: session_id should be indexed but not unique
vanmeeuwen added inline comments.
src/database/migrations/2021_01_13_120000_create_openvidu_connections_table.php
32

there should be an additional index on ['room_id', 'session_id'] because of Room.php 364

This revision now requires changes to proceed.Jan 19 2021, 10:57 AM
  • Improve constants handling
  • Add unique key on openvidu_connections.session_id
  • Fix: session_id should be indexed but not unique
  • Remove redundant where clause
This revision is now accepted and ready to land.Jan 19 2021, 3:29 PM
This revision was automatically updated to reflect the committed changes.