Page MenuHomekolab.org
Feed Advanced Search

Jul 14 2020

machniak committed rKc59e65eeb250: An initial stab at what it could mean to provide WebRTC through the new HKCCP (authored by vanmeeuwen).
An initial stab at what it could mean to provide WebRTC through the new HKCCP
Jul 14 2020, 2:21 PM

Jul 13 2020

machniak requested review of D1441: LDAP error handling, and tests.
Jul 13 2020, 9:41 AM

Jul 10 2020

machniak updated the diff for D1435: Token keep-alive (refresh).
  • Remove redundant code, add some unti tests
Jul 10 2020, 11:16 AM
machniak updated the diff for D1435: Token keep-alive (refresh).
  • Performance fix, double authentication fix
Jul 10 2020, 10:27 AM
machniak updated the diff for D1435: Token keep-alive (refresh).
  • Add tests for the refresh action
Jul 10 2020, 10:03 AM
machniak requested review of D1435: Token keep-alive (refresh).
Jul 10 2020, 9:01 AM
machniak committed rK3aeece83cdac: phpstan update fixes (authored by machniak).
phpstan update fixes
Jul 10 2020, 8:51 AM

Jul 9 2020

machniak requested review of D1429: Allow multiple ldap operations in a single connection.
Jul 9 2020, 10:52 AM
machniak committed rKa1f86db85908: Use slim version of jQuery (authored by machniak).
Use slim version of jQuery
Jul 9 2020, 10:03 AM

Jul 2 2020

machniak committed rK7554fffa9edc: Fix flaky tests and bitwise operator use (authored by machniak).
Fix flaky tests and bitwise operator use
Jul 2 2020, 12:58 PM

Jun 29 2020

machniak committed rKc5b4123bf4d9: Update js dependencies (authored by machniak).
Update js dependencies
Jun 29 2020, 2:33 PM
machniak requested review of D1423: Multiple-themes support.
Jun 29 2020, 1:35 PM

Jun 26 2020

machniak committed rKadf3f7419175: Update phpstan/larastan, add tests/Browser/ to phpstan analyze (authored by machniak).
Update phpstan/larastan, add tests/Browser/ to phpstan analyze
Jun 26 2020, 10:20 AM
machniak committed rK8d1452ae72bb: improve mail notificaions (authored by bohlender).
improve mail notificaions
Jun 26 2020, 8:38 AM
machniak closed D1414: improve mail notificaions.
Jun 26 2020, 8:38 AM

Jun 25 2020

machniak accepted D1414: improve mail notificaions.
Jun 25 2020, 2:57 PM
machniak requested changes to D1414: improve mail notificaions.
Jun 25 2020, 10:01 AM
machniak requested changes to D1414: improve mail notificaions.
Jun 25 2020, 9:38 AM

Jun 24 2020

machniak committed rK09591aff30dc: Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns (authored by machniak).
Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns
Jun 24 2020, 12:15 PM
machniak closed D1408: Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns.
Jun 24 2020, 12:15 PM
machniak committed rKf25d4dfb516b: Aliases sharing (authored by machniak).
Aliases sharing
Jun 24 2020, 12:15 PM
machniak closed D1402: Aliases sharing.
Jun 24 2020, 12:15 PM
machniak committed rKc72e9ef38ad9: Added production seeders (authored by machniak).
Added production seeders
Jun 24 2020, 12:15 PM
machniak closed D1390: Added production seeders.
Jun 24 2020, 12:14 PM

Jun 22 2020

machniak updated the diff for D1390: Added production seeders.
  • Update storage cost for production
Jun 22 2020, 11:02 AM

Jun 19 2020

machniak committed rK89d61e51f5bc: Fix flaky tests (authored by machniak).
Fix flaky tests
Jun 19 2020, 1:32 PM
machniak abandoned D1396: Fix created_at/updated_at on user settings added by UserObserver.

Abandoned in favour of https://git.kolab.org/D1408.

Jun 19 2020, 1:04 PM
machniak requested review of D1408: Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns.
Jun 19 2020, 1:04 PM
machniak updated the diff for D1402: Aliases sharing.
  • Limit alias duplicates to private domains
Jun 19 2020, 12:14 PM
machniak updated the diff for D1402: Aliases sharing.
  • Additional findByEmail() test
Jun 19 2020, 11:08 AM
machniak requested review of D1402: Aliases sharing.
Jun 19 2020, 10:22 AM

Jun 17 2020

machniak requested review of D1396: Fix created_at/updated_at on user settings added by UserObserver.
Jun 17 2020, 12:36 PM
machniak requested review of D1390: Added production seeders.
Jun 17 2020, 11:31 AM

Jun 15 2020

machniak committed rK01f9fcea44ce: Mobile UI fixes (authored by machniak).
Mobile UI fixes
Jun 15 2020, 3:19 PM
machniak closed D1384: Mobile UI fixes.
Jun 15 2020, 3:19 PM
machniak committed rK61b980f766d8: Display a notice about the wallet state (Bifrost#T348752) (authored by machniak).
Display a notice about the wallet state (Bifrost#T348752)
Jun 15 2020, 3:19 PM
machniak closed D1372: Display a notice about the wallet state (Bifrost#T348752).
Jun 15 2020, 3:19 PM
machniak committed rKb6a778523891: Add copyright and company details in the page footer (authored by machniak).
Add copyright and company details in the page footer
Jun 15 2020, 3:19 PM
machniak closed D1378: Add copyright and company details in the page footer.
Jun 15 2020, 3:19 PM
machniak committed rK037514191beb: Fix transaction description for domain entitlements (authored by machniak).
Fix transaction description for domain entitlements
Jun 15 2020, 3:19 PM
machniak closed D1366: Fix transaction description for domain entitlements.
Jun 15 2020, 3:19 PM
machniak committed rKfbf3f75e27ea: Make sure we bill for entitlements that are deleted (authored by machniak).
Make sure we bill for entitlements that are deleted
Jun 15 2020, 3:19 PM
machniak closed D1297: Make sure we bill for entitlements that are deleted.
Jun 15 2020, 3:19 PM
machniak updated the diff for D1378: Add copyright and company details in the page footer.
  • Hardcode copyright in the footer
Jun 15 2020, 3:09 PM
machniak updated the diff for D1384: Mobile UI fixes.
  • Add real favicon.ico
Jun 15 2020, 2:12 PM
machniak requested review of D1384: Mobile UI fixes.
Jun 15 2020, 1:03 PM

Jun 14 2020

machniak committed rK1e03ad3917a9: Bump js dependencies, fix linting issues (authored by machniak).
Bump js dependencies, fix linting issues
Jun 14 2020, 8:34 AM

Jun 12 2020

machniak requested review of D1378: Add copyright and company details in the page footer.
Jun 12 2020, 12:19 PM
machniak updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Rollback transactions on exceptions
  • Performance optimization
Jun 12 2020, 11:01 AM
machniak added a comment to D1051: improve wallet layout.

Partially implemented in https://git.kolab.org/D1372 and we decided to not implement the costs overview table. So, I think this differential could be abandoned.

Jun 12 2020, 8:59 AM
machniak requested review of D1372: Display a notice about the wallet state (Bifrost#T348752).
Jun 12 2020, 8:55 AM

Jun 11 2020

machniak updated the summary of D1366: Fix transaction description for domain entitlements.
Jun 11 2020, 9:20 AM
machniak requested review of D1366: Fix transaction description for domain entitlements.
Jun 11 2020, 9:16 AM

Jun 10 2020

machniak committed rKc4818aadb932: Small css fix (authored by machniak).
Small css fix
Jun 10 2020, 3:10 PM
machniak committed rK5b736c1c9b50: Fix font-size on small elements (authored by machniak).
Fix font-size on small elements
Jun 10 2020, 3:10 PM
machniak committed rK5819373d54ff: Improve error handling on signup welcome page (authored by machniak).
Improve error handling on signup welcome page
Jun 10 2020, 3:10 PM
machniak committed rK98d3e8702b7e: Fix linting issues and a regression in browser tests (authored by machniak).
Fix linting issues and a regression in browser tests
Jun 10 2020, 12:31 PM
machniak committed rKf4537ed38a96: VAT on Receipts (authored by machniak).
VAT on Receipts
Jun 10 2020, 11:56 AM
machniak closed D1327: VAT on Receipts.
Jun 10 2020, 11:56 AM
machniak committed rK92c7f9f21811: Receipts UI (authored by machniak).
Receipts UI
Jun 10 2020, 11:56 AM
machniak closed D1348: Receipts UI.
Jun 10 2020, 11:56 AM
machniak updated the diff for D1348: Receipts UI.
  • Fix History tab after rabease
Jun 10 2020, 11:54 AM
machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
  • Rebase
Jun 10 2020, 11:45 AM
machniak committed rK90da82738276: Transaction log in admin UI (authored by machniak).
Transaction log in admin UI
Jun 10 2020, 11:41 AM
machniak closed D1360: Transaction log in admin UI.
Jun 10 2020, 11:41 AM
machniak committed rKda13578ce560: Wallet magic (authored by machniak).
Wallet magic
Jun 10 2020, 11:41 AM
machniak closed D1150: Wallet magic.
Jun 10 2020, 11:41 AM
machniak committed rK534d00000831: Cherry-picked contents from hkccp-import (authored by vanmeeuwen).
Cherry-picked contents from hkccp-import
Jun 10 2020, 11:41 AM
machniak closed D1291: Cherry-picked contents from hkccp-import.
Jun 10 2020, 11:41 AM
machniak committed rK0481c595510a: Add plain text parts to email (authored by machniak).
Add plain text parts to email
Jun 10 2020, 11:41 AM
machniak closed D1354: Add plain text parts to email.
Jun 10 2020, 11:41 AM
machniak added inline comments to D1360: Transaction log in admin UI.
Jun 10 2020, 10:58 AM
machniak updated the diff for D1360: Transaction log in admin UI.
  • Small code improvements
Jun 10 2020, 8:59 AM
machniak requested review of D1360: Transaction log in admin UI.
Jun 10 2020, 8:14 AM

Jun 9 2020

machniak committed rK7dc1e3fa2ee8: Limit number of records the test works with, code improvements (authored by machniak).
Limit number of records the test works with, code improvements
Jun 9 2020, 11:12 AM
machniak requested review of D1354: Add plain text parts to email.
Jun 9 2020, 10:47 AM

Jun 8 2020

machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
Jun 8 2020, 12:03 PM
machniak requested review of D1348: Receipts UI.
Jun 8 2020, 8:49 AM

Jun 5 2020

machniak requested changes to D1150: Wallet magic.

@vanmeeuwen, I rebased, fixed obvious bugs and refactored the code so now we have Wallet::balanceLastsUntil() that we need tests for in tests/Feature/WalletTest::testBalanceLastsUntil().

Jun 5 2020, 1:47 PM
machniak updated the diff for D1150: Wallet magic.
  • Fix error due to missing use statements
  • Create Wallet::balanceLastsUntil()
Jun 5 2020, 1:44 PM
machniak added inline comments to D1297: Make sure we bill for entitlements that are deleted.
Jun 5 2020, 1:09 PM
machniak requested changes to D1297: Make sure we bill for entitlements that are deleted.

This learned us that an exception does not rollback uncommitted transactions. Here's a general fix for this issue:

--- a/src/app/Exceptions/Handler.php
+++ b/src/app/Exceptions/Handler.php
@@ -5,6 +5,7 @@ namespace App\Exceptions;
 use Exception;
 use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Support\Facades\DB;
Jun 5 2020, 12:50 PM
machniak committed rK35814db70a9c: Fix test failing when executed more than once (authored by machniak).
Fix test failing when executed more than once
Jun 5 2020, 9:34 AM
machniak accepted D1291: Cherry-picked contents from hkccp-import.

My comments to src/app/Domain.php were not addressed, but it's not critical.

Jun 5 2020, 9:01 AM
machniak updated the diff for D1327: VAT on Receipts.
  • Render fake receipt with VAT
Jun 5 2020, 8:26 AM

Jun 4 2020

machniak committed rK279da5dfbdc1: Fix regression, improve button labels (authored by machniak).
Fix regression, improve button labels
Jun 4 2020, 4:22 PM
machniak requested review of D1327: VAT on Receipts.
Jun 4 2020, 3:07 PM
machniak committed rK10f2840186b8: Wallet history (authored by machniak).
Wallet history
Jun 4 2020, 1:59 PM
machniak closed D1321: Wallet history.
Jun 4 2020, 1:59 PM
machniak updated the diff for D1321: Wallet history.
  • Top-up -> Payment
Jun 4 2020, 1:58 PM
machniak committed rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896) (authored by machniak).
Support: Awarding a bonus or penalty (Bifrost#T315896)
Jun 4 2020, 12:53 PM
machniak closed D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 12:53 PM
machniak requested review of D1321: Wallet history.
Jun 4 2020, 12:47 PM
machniak committed rK5df6db72a947: Receipt document (html and pdf) (authored by machniak).
Receipt document (html and pdf)
Jun 4 2020, 10:34 AM
machniak closed D1309: Receipt document (html and pdf).
Jun 4 2020, 10:33 AM
machniak added a comment to D1315: Return an empty body element for empty descriptions.

The spec. says Body is optional. https://docs.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascal/70161e94-3b50-4d20-8c4d-e3ca608f9dc8

Jun 4 2020, 9:37 AM

Jun 3 2020

machniak committed rKc4f6f1b8b280: Wallet charge: top-ups and notifications (authored by machniak).
Wallet charge: top-ups and notifications
Jun 3 2020, 12:27 PM
machniak closed D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 12:26 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix typo
Jun 3 2020, 12:14 PM
machniak added inline comments to D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 9:41 AM