Page MenuHomekolab.org

Aliases sharing
ClosedPublic

Authored by machniak on Jun 19 2020, 10:22 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKf25d4dfb516b: Aliases sharing
Summary

Support assigning the same alias to different users (of the same account)

Test Plan

php artisan migrate:refresh --seed; ./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Jun 19 2020, 10:22 AM
machniak created this revision.
machniak updated this revision to Diff 3709.Jun 19 2020, 11:08 AM
  • Additional findByEmail() test

This would inadvertently allow john@mykolab.com to create jane@mykolab.com, and add duplicate aliases to both accounts.

While we would not be able to migrate duplicate aliases for individual users to distribution groups, without offering distribution groups to individuals (and we want to reserve that functionality for groups), it seems reasonable to consider a duplicate alias to not be allowed if the domain for it is public.

vanmeeuwen requested changes to this revision.Jun 19 2020, 11:49 AM
This revision now requires changes to proceed.Jun 19 2020, 11:49 AM
machniak updated this revision to Diff 3715.Jun 19 2020, 12:14 PM
  • Limit alias duplicates to private domains
vanmeeuwen accepted this revision.Jun 24 2020, 12:02 PM
This revision is now accepted and ready to land.Jun 24 2020, 12:02 PM
This revision was automatically updated to reflect the committed changes.