Page MenuHomePhorge

Aliases sharing
ClosedPublic

Authored by machniak on Jun 19 2020, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 1 2024, 9:13 AM
Unknown Object (File)
Jan 31 2024, 7:32 PM
Unknown Object (File)
Jan 28 2024, 11:08 PM
Unknown Object (File)
Jan 20 2024, 2:14 PM
Unknown Object (File)
Jan 19 2024, 11:25 AM
Unknown Object (File)
Jan 19 2024, 10:10 AM
Unknown Object (File)
Jan 19 2024, 9:21 AM
Unknown Object (File)
Jan 18 2024, 12:38 AM
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKf25d4dfb516b: Aliases sharing
Summary

Support assigning the same alias to different users (of the same account)

Test Plan

php artisan migrate:refresh --seed; ./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/aliases-fix
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29908
Build 11095: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Additional findByEmail() test

This would inadvertently allow john@mykolab.com to create jane@mykolab.com, and add duplicate aliases to both accounts.

While we would not be able to migrate duplicate aliases for individual users to distribution groups, without offering distribution groups to individuals (and we want to reserve that functionality for groups), it seems reasonable to consider a duplicate alias to not be allowed if the domain for it is public.

This revision now requires changes to proceed.Jun 19 2020, 11:49 AM
  • Limit alias duplicates to private domains
This revision is now accepted and ready to land.Jun 24 2020, 12:02 PM
This revision was automatically updated to reflect the committed changes.