Page MenuHomekolab.org

improve mail notificaions
ClosedPublic

Authored by bohlender on Thu, Jun 25, 6:09 AM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK8d1452ae72bb: improve mail notificaions
Summary

improve html mail notification layout

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bohlender requested review of this revision.Thu, Jun 25, 6:09 AM
bohlender created this revision.
bohlender added a reviewer: Restricted Project.Thu, Jun 25, 6:11 AM
bohlender added a subscriber: Restricted Project.
machniak requested changes to this revision.Thu, Jun 25, 9:38 AM
machniak added a subscriber: machniak.
machniak added inline comments.
src/resources/views/emails/html/suspended_debtor.blade.php
22–23

Here and in a few other places, missing space after ).

src/resources/views/emails/plain/negative_balance.blade.php
16–17

The space after -- wasn't a typo, it must be there.

src/resources/views/emails/plain/signup_code.blade.php
5

You removed the link. It should stay there, after body2 now.

This revision now requires changes to proceed.Thu, Jun 25, 9:38 AM
bohlender updated this revision to Diff 3757.Thu, Jun 25, 9:53 AM
  • missing space after --
  • )}} > ) }}
  • re-added link for plaintext signup message
bohlender marked 3 inline comments as done.Thu, Jun 25, 9:54 AM
machniak requested changes to this revision.Thu, Jun 25, 10:01 AM
machniak added inline comments.
src/resources/views/emails/html/payment_success.blade.php
17

Syntax error, missing }. And the space after it is redundant. I think you should run ./phpunit --testsuite=Unit, to see if mail content tests still work.

This revision now requires changes to proceed.Thu, Jun 25, 10:01 AM
bohlender updated this revision to Diff 3763.Thu, Jun 25, 10:25 AM
  • fix syntax error
  • remove whitespace
machniak accepted this revision.Thu, Jun 25, 2:57 PM
This revision is now accepted and ready to land.Thu, Jun 25, 2:57 PM
This revision was automatically updated to reflect the committed changes.