Page MenuHomePhorge

improve mail notificaions
ClosedPublic

Authored by bohlender on Jun 25 2020, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 7:32 PM
Unknown Object (File)
Fri, Mar 1, 11:06 PM
Unknown Object (File)
Fri, Mar 1, 11:25 AM
Unknown Object (File)
Fri, Mar 1, 11:18 AM
Unknown Object (File)
Feb 25 2024, 7:50 PM
Unknown Object (File)
Feb 21 2024, 9:57 PM
Unknown Object (File)
Feb 15 2024, 12:37 AM
Unknown Object (File)
Feb 13 2024, 5:55 AM
Subscribers
Restricted Project

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK8d1452ae72bb: improve mail notificaions
Summary

improve html mail notification layout

Diff Detail

Repository
rK kolab
Branch
dev/mailnotificaitons
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29962
Build 11134: arc lint + arc unit

Event Timeline

bohlender created this revision.
bohlender added a reviewer: Restricted Project.Jun 25 2020, 6:11 AM
bohlender added a subscriber: Restricted Project.
machniak subscribed.
machniak added inline comments.
src/resources/views/emails/html/suspended_debtor.blade.php
22โ€“23

Here and in a few other places, missing space after ).

src/resources/views/emails/plain/negative_balance.blade.php
16โ€“17

The space after -- wasn't a typo, it must be there.

src/resources/views/emails/plain/signup_code.blade.php
5

You removed the link. It should stay there, after body2 now.

This revision now requires changes to proceed.Jun 25 2020, 9:38 AM
  • missing space after --
  • )}} > ) }}
  • re-added link for plaintext signup message
machniak added inline comments.
src/resources/views/emails/html/payment_success.blade.php
17

Syntax error, missing }. And the space after it is redundant. I think you should run ./phpunit --testsuite=Unit, to see if mail content tests still work.

This revision now requires changes to proceed.Jun 25 2020, 10:01 AM
  • fix syntax error
  • remove whitespace
This revision is now accepted and ready to land.Jun 25 2020, 2:57 PM
This revision was automatically updated to reflect the committed changes.