Page MenuHomePhorge

Multiple-themes support
ClosedPublic

Authored by machniak on Jun 29 2020, 1:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 15, 2:28 AM
Unknown Object (File)
Tue, Jul 9, 6:47 PM
Unknown Object (File)
Thu, Jul 4, 12:17 PM
Unknown Object (File)
Tue, Jun 25, 6:50 AM
Unknown Object (File)
Thu, Jun 20, 11:45 PM
Unknown Object (File)
Jun 12 2024, 8:52 PM
Unknown Object (File)
Jun 8 2024, 8:35 PM
Unknown Object (File)
May 27 2024, 1:39 AM
Subscribers
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK9343596821a3: Multiple-themes support
Summary

Here's how I see theme installation after this is merged:

  • move theme directory (from an external repo) into resources/themes/<name>
  • run npm run dev (this will put generated files and theme resources under public/themes/<name>

There a couple of new config options that will need to be set.

APP_THEME=default
WEBMAIL_URL=/apps
SUPPORT_URL=/support
SUPPORT_EMAIL=

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
  • Merge branch 'master' into dev/themes
  • Configurable menu
  • Theming: Support for static pages
  • Merge branch 'master' into dev/themes

Looks like src/resources/themes/default has some kolabnow assets left. is that by intention ?
Any objections to adding src/public/themes to .gitignore?

Could you elaborate why you choose to go with blade theming, the purist in me wants it all to be vue components?

  • Remove kolabnow theme, it exists in a separate repo

Looks like src/resources/themes/default has some kolabnow assets left. is that by intention ?

Default theme needs to stay. At some point we might change it, maybe simplify, but for now I need it as-is at least to keep browser tests working.

Any objections to adding src/public/themes to .gitignore?

Except for themes/default.

Could you elaborate why you choose to go with blade theming, the purist in me wants it all to be vue components?

I don't want them to be included with the app. It could be vue components, but then they would have to be loaded dynamically. I didn't investigate that feature yet. And untill we don't need our static pages to interact with the app there's no need for that.

  • Admin menu and root redirect to dashboard
  • Support contact form
  • Add tests for SupportController
  • Fix browser tests regression
  • Add tests for support page/form
  • Remove 404.vue
  • Support form improvements
  • Use default Bootstrap colors
  • Merge branch 'master' into dev/themes
  • Make webmail location configurable, add webmail link on logon page, fix test
  • Remove hardcoded references to KolabNow
  • Define FAQ entries per page via theme.json
This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2020, 10:03 AM
This revision was automatically updated to reflect the committed changes.