Page MenuHomekolab.org

Multiple-themes support
ClosedPublic

Authored by machniak on Jun 29 2020, 1:34 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK9343596821a3: Multiple-themes support
Summary

Here's how I see theme installation after this is merged:

  • move theme directory (from an external repo) into resources/themes/<name>
  • run npm run dev (this will put generated files and theme resources under public/themes/<name>

There a couple of new config options that will need to be set.

APP_THEME=default
WEBMAIL_URL=/apps
SUPPORT_URL=/support
SUPPORT_EMAIL=

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Jun 29 2020, 1:34 PM
machniak created this revision.
machniak updated this revision to Diff 4618.Oct 8 2020, 1:38 PM
  • Merge branch 'master' into dev/themes
  • Configurable menu
  • Theming: Support for static pages
machniak updated this revision to Diff 4624.Oct 8 2020, 1:43 PM
  • Remove unused icons
machniak updated this revision to Diff 4708.Oct 13 2020, 2:10 PM
  • Merge branch 'master' into dev/themes

Looks like src/resources/themes/default has some kolabnow assets left. is that by intention ?
Any objections to adding src/public/themes to .gitignore?

Could you elaborate why you choose to go with blade theming, the purist in me wants it all to be vue components?

machniak updated this revision to Diff 4774.Oct 16 2020, 1:21 PM
  • Remove kolabnow theme, it exists in a separate repo

Looks like src/resources/themes/default has some kolabnow assets left. is that by intention ?

Default theme needs to stay. At some point we might change it, maybe simplify, but for now I need it as-is at least to keep browser tests working.

Any objections to adding src/public/themes to .gitignore?

Except for themes/default.

Could you elaborate why you choose to go with blade theming, the purist in me wants it all to be vue components?

I don't want them to be included with the app. It could be vue components, but then they would have to be loaded dynamically. I didn't investigate that feature yet. And untill we don't need our static pages to interact with the app there's no need for that.

machniak updated this revision to Diff 4858.Oct 20 2020, 10:30 AM
  • Small style fixes
machniak updated this revision to Diff 4888.Oct 20 2020, 1:48 PM
  • Admin menu and root redirect to dashboard
machniak updated this revision to Diff 4894.Oct 20 2020, 1:52 PM
  • Get rid of unused icons
machniak updated this revision to Diff 4900.Oct 21 2020, 3:35 PM
  • Support contact form
  • Add tests for SupportController
machniak updated this revision to Diff 4906.Oct 22 2020, 2:47 PM
  • Fix browser tests regression
  • Add tests for support page/form
  • Remove 404.vue
  • Support form improvements
machniak updated this revision to Diff 4912.Oct 22 2020, 3:09 PM
  • Use default Bootstrap colors
  • Merge branch 'master' into dev/themes
machniak updated this revision to Diff 4966.Oct 28 2020, 11:28 AM
  • Make webmail location configurable, add webmail link on logon page, fix test
  • Remove hardcoded references to KolabNow
machniak updated this revision to Diff 4972.Oct 28 2020, 3:30 PM
  • Define FAQ entries per page via theme.json
machniak edited the summary of this revision. (Show Details)Nov 3 2020, 7:39 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2020, 10:03 AM
This revision was automatically updated to reflect the committed changes.