Project Tags

None

Referenced Files

	F117927808: D1423.1775456558.diff
	Sun, Apr 5, 6:22 AM

	F117926914: D1423.1775453058.diff
	Sun, Apr 5, 5:24 AM

	F117926717: D1423.1775452381.diff
	Sun, Apr 5, 5:13 AM

	F117921517: D1423.1775431567.diff
	Sat, Apr 4, 11:26 PM

	F117919377: D1423.1775423060.diff
	Sat, Apr 4, 9:04 PM

	F117916074: D1423.1775408954.diff
	Sat, Apr 4, 5:09 PM

	F117886876: D1423.1775357111.diff
	Sat, Apr 4, 2:45 AM

	F117885354: D1423.1775354343.diff
	Sat, Apr 4, 1:59 AM

Subscribers

bohlender

Restricted Project

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK9343596821a3: Multiple-themes support

Summary

Here's how I see theme installation after this is merged:

move theme directory (from an external repo) into resources/themes/<name>
run npm run dev (this will put generated files and theme resources under public/themes/<name>

There a couple of new config options that will need to be set.

APP_THEME=default
WEBMAIL_URL=/apps
SUPPORT_URL=/support
SUPPORT_EMAIL=

Diff Detail

Repository

rK kolab

Branch

dev/themes

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31312
Build 11833: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jun 29 2020, 11:34 AM

machniak created this revision.

Harbormaster completed remote builds in B29980: Diff 3775.Jun 29 2020, 11:35 AM

Merge branch 'master' into dev/themes
Configurable menu
Theming: Support for static pages

Harbormaster completed remote builds in B31210: Diff 4618.Oct 8 2020, 11:38 AM

Remove unused icons

Harbormaster completed remote builds in B31216: Diff 4624.Oct 8 2020, 11:43 AM

Merge branch 'master' into dev/themes

Harbormaster completed remote builds in B31312: Diff 4708.Oct 13 2020, 12:10 PM

Looks like src/resources/themes/default has some kolabnow assets left. is that by intention ?
Any objections to adding src/public/themes to .gitignore?

Could you elaborate why you choose to go with blade theming, the purist in me wants it all to be vue components?

Remove kolabnow theme, it exists in a separate repo

Harbormaster completed remote builds in B31375: Diff 4774.Oct 16 2020, 11:21 AM

In D1423#19876, @bohlender wrote:

Looks like src/resources/themes/default has some kolabnow assets left. is that by intention ?

Default theme needs to stay. At some point we might change it, maybe simplify, but for now I need it as-is at least to keep browser tests working.

Any objections to adding src/public/themes to .gitignore?

Except for themes/default.

Could you elaborate why you choose to go with blade theming, the purist in me wants it all to be vue components?

I don't want them to be included with the app. It could be vue components, but then they would have to be loaded dynamically. I didn't investigate that feature yet. And untill we don't need our static pages to interact with the app there's no need for that.

Small style fixes

Harbormaster completed remote builds in B31456: Diff 4858.Oct 20 2020, 8:30 AM

Admin menu and root redirect to dashboard

Harbormaster completed remote builds in B31483: Diff 4888.Oct 20 2020, 11:48 AM

Get rid of unused icons

Harbormaster completed remote builds in B31486: Diff 4894.Oct 20 2020, 11:52 AM

Support contact form
Add tests for SupportController

Harbormaster completed remote builds in B31492: Diff 4900.Oct 21 2020, 1:35 PM

Fix browser tests regression
Add tests for support page/form
Remove 404.vue
Support form improvements

Harbormaster completed remote builds in B31498: Diff 4906.Oct 22 2020, 12:47 PM

machniak mentioned this in D1648: Add Webmail link to the dashboard, remove from the menu.Oct 22 2020, 12:50 PM

Use default Bootstrap colors
Merge branch 'master' into dev/themes

Harbormaster completed remote builds in B31501: Diff 4912.Oct 22 2020, 1:09 PM

Make webmail location configurable, add webmail link on logon page, fix test
Remove hardcoded references to KolabNow

Harbormaster completed remote builds in B31615: Diff 4966.Oct 28 2020, 10:28 AM

Define FAQ entries per page via theme.json

Harbormaster completed remote builds in B31621: Diff 4972.Oct 28 2020, 2:30 PM

machniak edited the summary of this revision. (Show Details)Nov 3 2020, 6:39 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2020, 9:03 AM

Closed by commit rK9343596821a3: Multiple-themes support. · Explain Why

This revision was automatically updated to reflect the committed changes.

Multiple-themes supportClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4708

src/.env.example

src/app/Documents/Receipt.php

src/app/Http/Controllers/ContentController.php

src/app/Providers/AppServiceProvider.php

src/app/Utils.php

src/config/app.php

src/config/view.php

src/public/images/favicon.ico

src/public/images/icons/icon-128x128.png

src/public/images/icons/icon-144x144.png

src/public/images/icons/icon-152x152.png

src/public/images/icons/icon-192x192.png

src/public/images/icons/icon-384x384.png

src/public/images/icons/icon-512x512.png

src/public/images/icons/icon-72x72.png

src/public/images/icons/icon-96x96.png

src/public/images/icons/splash-1125x2436.png

src/public/images/icons/splash-1242x2208.png

src/public/images/icons/splash-1242x2688.png

src/public/images/icons/splash-1536x2048.png

src/public/images/icons/splash-1668x2224.png

src/public/images/icons/splash-1668x2388.png

src/public/images/icons/splash-2048x2732.png

src/public/images/icons/splash-640x1136.png

src/public/images/icons/splash-750x1334.png

src/public/images/icons/splash-828x1792.png

src/public/images/logo.svg

src/public/images/logo_footer.png

src/public/images/logo_header.png

src/public/images/logo_print.svg

src/public/mix-manifest.json

src/readme.md

src/resources/js/app.js

src/resources/js/bootstrap.js

src/resources/js/routes-user.js

src/resources/sass/_variables.scss

src/resources/sass/app.scss

src/resources/sass/bootstrap.scss

src/resources/sass/document.scss

src/resources/sass/forms.scss

src/resources/sass/menu.scss

src/resources/sass/toast.scss

src/resources/themes/README.md

src/resources/themes/app.scss

src/resources/themes/bootstrap.scss

src/resources/themes/default/_variables.scss

src/resources/themes/default/app.scss

src/resources/themes/default/document.scss

src/resources/themes/default/images/favicon.ico

src/resources/themes/default/images/icons/icon-128x128.png

src/resources/themes/default/images/icons/icon-144x144.png

src/resources/themes/default/images/icons/icon-152x152.png

src/resources/themes/default/images/icons/icon-192x192.png

src/resources/themes/default/images/icons/icon-384x384.png

src/resources/themes/default/images/icons/icon-512x512.png

src/resources/themes/default/images/icons/icon-72x72.png

src/resources/themes/default/images/icons/icon-96x96.png

src/resources/themes/default/images/icons/splash-1125x2436.png

src/resources/themes/default/images/icons/splash-1242x2208.png

src/resources/themes/default/images/icons/splash-1242x2688.png

src/resources/themes/default/images/icons/splash-1536x2048.png

src/resources/themes/default/images/icons/splash-1668x2224.png

src/resources/themes/default/images/icons/splash-1668x2388.png

src/resources/themes/default/images/icons/splash-2048x2732.png

src/resources/themes/default/images/icons/splash-640x1136.png

src/resources/themes/default/images/icons/splash-750x1334.png

src/resources/themes/default/images/icons/splash-828x1792.png

src/resources/themes/default/images/logo.svg

src/resources/themes/default/images/logo_footer.png

src/resources/themes/default/images/logo_header.png

src/resources/themes/default/images/logo_print.svg

src/resources/themes/default/theme.json

src/resources/themes/document.scss

src/resources/themes/forms.scss

Multiple-themes support
ClosedPublic
Actions

Revision Contents
Changeset List