Paths

Table of Contentst

Differential D1360

Transaction log in admin UI
ClosedPublic
Actions

Authored by machniak on Jun 10 2020, 8:14 AM.

Tags

None

Referenced Files

	F10580941: D1360.id.diff
	Thu, Nov 30, 1:23 PM

	Unknown Object (File)
	Sun, Nov 5, 6:33 PM

	Unknown Object (File)
	Fri, Nov 3, 10:23 AM

	Unknown Object (File)
	Thu, Nov 2, 9:30 AM

	Unknown Object (File)
	Nov 1 2023, 3:16 AM

	Unknown Object (File)
	Oct 25 2023, 1:01 PM

	Unknown Object (File)
	Oct 21 2023, 2:57 PM

	Unknown Object (File)
	Oct 18 2023, 12:10 PM

View All 17 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK90da82738276: Transaction log in admin UI

Summary

Created TransactionLog widget, which is now used in User and Admin apps.
The transaction log table for admins displays additonal User column.

Test Plan

./phpunit

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Jun 10 2020, 8:14 AM

machniak created this revision.

Harbormaster completed remote builds in B29764: Diff 3583.Jun 10 2020, 8:14 AM

Small code improvements

Harbormaster completed remote builds in B29770: Diff 3589.Jun 10 2020, 8:59 AM

bohlender subscribed.Jun 10 2020, 10:13 AM

bohlender added inline comments.

src/resources/vue/Admin/User.vue
149	shouldn't the title be conditionally rendered as well ?
src/resources/vue/Domain/Info.vue
3	Are we going to use the shorthand for v-bind (and v-on) exclusively ?

machniak added inline comments.Jun 10 2020, 10:58 AM

src/resources/vue/Admin/User.vue
149	The v-if here is not to not render the table, but to render it when it is ready. So, it will always be there.
src/resources/vue/Domain/Info.vue
3	This is what our current linter suggests. `npm run lint`.

vanmeeuwen accepted this revision.Jun 10 2020, 11:32 AM

This revision is now accepted and ready to land.Jun 10 2020, 11:32 AM

Closed by commit rK90da82738276: Transaction log in admin UI (authored by machniak). · Explain WhyJun 10 2020, 11:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Http/

Controllers/

API/

V4/

WalletsController.php

11 lines

resources/

sass/

1 line

vue/

Admin/

26 lines

2 lines

Domain/

2 lines

User/

2 lines

102 lines

Widgets/

TransactionLog.vue

122 lines

routes/

1 line

tests/

Browser/

Admin/

UserFinancesTest.php

314 lines

210 lines

1 line

Feature/

Controller/

Admin/

WalletsTest.php

45 lines

WalletsTest.php

2 lines

TestCaseTrait.php

2 lines

Diff 3604

src/app/Http/Controllers/API/V4/WalletsController.php

Loading...

src/resources/sass/app.scss

Loading...

src/resources/vue/Admin/User.vue

Loading...

src/resources/vue/Dashboard.vue

Loading...

src/resources/vue/Domain/Info.vue

Loading...

src/resources/vue/User/Info.vue

Loading...

src/resources/vue/Wallet.vue

Loading...

src/resources/vue/Widgets/TransactionLog.vue

Loading...

src/routes/api.php

Loading...

src/tests/Browser/Admin/UserFinancesTest.php

Loading...

src/tests/Browser/Admin/UserTest.php

Loading...

src/tests/Browser/WalletTest.php

Loading...

src/tests/Feature/Controller/Admin/WalletsTest.php

Loading...

src/tests/Feature/Controller/WalletsTest.php

Loading...

src/tests/TestCaseTrait.php

Loading...