Page MenuHomekolab.org

Transaction log in admin UI
ClosedPublic

Authored by machniak on Jun 10 2020, 8:14 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK90da82738276: Transaction log in admin UI
Summary

Created TransactionLog widget, which is now used in User and Admin apps.
The transaction log table for admins displays additonal User column.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Jun 10 2020, 8:14 AM
machniak created this revision.
machniak updated this revision to Diff 3589.Jun 10 2020, 8:59 AM
  • Small code improvements
bohlender added inline comments.
src/resources/vue/Admin/User.vue
149

shouldn't the title be conditionally rendered as well ?

src/resources/vue/Domain/Info.vue
3

Are we going to use the shorthand for v-bind (and v-on) exclusively ?

machniak added inline comments.Jun 10 2020, 10:58 AM
src/resources/vue/Admin/User.vue
149

The v-if here is not to not render the table, but to render it when it is ready. So, it will always be there.

src/resources/vue/Domain/Info.vue
3

This is what our current linter suggests. npm run lint.

vanmeeuwen accepted this revision.Jun 10 2020, 11:32 AM
This revision is now accepted and ready to land.Jun 10 2020, 11:32 AM
This revision was automatically updated to reflect the committed changes.