Page MenuHomekolab.org

Fix transaction description for domain entitlements
ClosedPublic

Authored by machniak on Thu, Jun 11, 9:16 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK037514191beb: Fix transaction description for domain entitlements
Summary
  • Fixed the bug
  • Refactored code for better performance
  • Moved user_email setting to the observer
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Thu, Jun 11, 9:16 AM
machniak created this revision.
machniak edited the summary of this revision. (Show Details)Thu, Jun 11, 9:20 AM
vanmeeuwen requested changes to this revision.Mon, Jun 15, 2:53 PM
vanmeeuwen added a subscriber: vanmeeuwen.

One question for the whodunnit.

This revision now requires changes to proceed.Mon, Jun 15, 2:53 PM

With question ;-)

src/app/Entitlement.php
87–88

Why would we not include the whodunnit here?

vanmeeuwen accepted this revision.Mon, Jun 15, 2:59 PM
This revision is now accepted and ready to land.Mon, Jun 15, 2:59 PM
This revision was automatically updated to reflect the committed changes.