Page MenuHomekolab.org

Support: Awarding a bonus or penalty (Bifrost#T315896)
ClosedPublic

Authored by machniak on May 14 2020, 12:52 PM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896)
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.May 14 2020, 12:52 PM
machniak created this revision.
bohlender added inline comments.
src/resources/vue/Admin/User.vue
304–338

We seem make more use of modals lately. I wonder if going with changing the user interface inline might provide a better user experience.
But I would not really bother for the support interface

machniak updated this revision to Diff 3460.May 29 2020, 8:17 AM
  • Use transaction log
machniak edited the summary of this revision. (Show Details)May 29 2020, 8:18 AM
vanmeeuwen accepted this revision.Jun 4 2020, 12:49 PM
This revision is now accepted and ready to land.Jun 4 2020, 12:49 PM
This revision was automatically updated to reflect the committed changes.

Just one labeling issue were we could be clearer. The rest looks good

src/resources/vue/Admin/User.vue
141

I'd label the buttons "add bonus" / "add penalty"