Page MenuHomekolab.org

Wallet history
ClosedPublic

Authored by machniak on Jun 4 2020, 12:47 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK10f2840186b8: Wallet history
Summary

Transactions log in the customer UI. Added "History" tab in the wallet page.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Jun 4 2020, 12:47 PM
machniak created this revision.
bohlender added inline comments.
src/resources/lang/en/transactions.php
18

I'd use payment instead of top-up to be consistent with the language from the rest of the payment UI.

It might also make sense to distinguish between "manual payment" and "auto payment" here.

19

If we can afford it, I'd forgo the "deduction" label and just list all Charges outright.
Not a huge issue though and what we currently have is totally fine for the first iteration.

machniak updated this revision to Diff 3520.Jun 4 2020, 1:58 PM
  • Top-up -> Payment
This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2020, 1:59 PM
Closed by commit rK10f2840186b8: Wallet history (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.