Paths

Table of Contentst

Differential D1321

Wallet history
ClosedPublic
Actions

Authored by machniak on Jun 4 2020, 12:47 PM.

Tags

None

Referenced Files

	F11779281: D1321.diff
	Thu, Apr 18, 6:58 AM

	Unknown Object (File)
	Mon, Apr 15, 7:59 AM

	Unknown Object (File)
	Fri, Apr 12, 6:12 PM

	Unknown Object (File)
	Tue, Apr 9, 9:55 AM

	Unknown Object (File)
	Tue, Apr 9, 6:19 AM

	Unknown Object (File)
	Sat, Mar 30, 11:50 AM

	Unknown Object (File)
	Feb 13 2024, 9:18 PM

	Unknown Object (File)
	Feb 13 2024, 3:33 PM

View All 39 Files

Subscribers

Restricted Project

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK10f2840186b8: Wallet history

Summary

Transactions log in the customer UI. Added "History" tab in the wallet page.

Test Plan

./phpunit

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Jun 4 2020, 12:47 PM

machniak created this revision.

Harbormaster completed remote builds in B29680: Diff 3508.Jun 4 2020, 12:47 PM

bohlender subscribed.Jun 4 2020, 1:15 PM

bohlender added inline comments.

src/resources/lang/en/transactions.php
18	I'd use payment instead of top-up to be consistent with the language from the rest of the payment UI. It might also make sense to distinguish between "manual payment" and "auto payment" here.
19	If we can afford it, I'd forgo the "deduction" label and just list all Charges outright. Not a huge issue though and what we currently have is totally fine for the first iteration.

Top-up -> Payment

Harbormaster completed remote builds in B29692: Diff 3520.Jun 4 2020, 1:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2020, 1:59 PM

Closed by commit rK10f2840186b8: Wallet history (authored by machniak). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

WalletTransactions.php

2 lines

Http/

Controllers/

API/

V4/

WalletsController.php

79 lines

Transaction.php

19 lines

14 lines

10 lines

3 lines

resources/

lang/

en/

transactions.php

11 lines

sass/

25 lines

vue/

112 lines

routes/

1 line

tests/

Browser/

Pages/

2 lines

76 lines

Feature/

Controller/

WalletsTest.php

150 lines

TestCaseTrait.php

69 lines

Unit/

32 lines

Diff 3523

src/app/Console/Commands/WalletTransactions.php

Loading...

src/app/Http/Controllers/API/V4/WalletsController.php

Loading...

src/app/Transaction.php

Loading...

src/app/User.php

Loading...

src/app/Wallet.php

Loading...

src/phpstan.neon

Loading...

src/resources/lang/en/transactions.php

Loading...

src/resources/sass/app.scss

Loading...

src/resources/vue/Wallet.vue

Loading...

src/routes/api.php

Loading...

src/tests/Browser/Pages/Wallet.php

Loading...

src/tests/Browser/WalletTest.php

Loading...

src/tests/Feature/Controller/WalletsTest.php

Loading...

src/tests/TestCaseTrait.php

Loading...

src/tests/Unit/WalletTest.php

Loading...