Wallet history
ClosedPublic
Actions

Authored by machniak on Jun 4 2020, 12:47 PM.

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK10f2840186b8: Wallet history

Summary

Transactions log in the customer UI. Added "History" tab in the wallet page.

Test Plan

./phpunit

Repository

rK kolab

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

machniak requested review of this revision.Jun 4 2020, 12:47 PM

machniak created this revision.

bohlender added inline comments.

src/resources/lang/en/transactions.php
18	I'd use payment instead of top-up to be consistent with the language from the rest of the payment UI. It might also make sense to distinguish between "manual payment" and "auto payment" here.
19	If we can afford it, I'd forgo the "deduction" label and just list all Charges outright. Not a huge issue though and what we currently have is totally fine for the first iteration.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2020, 1:59 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/app/Console/Commands/WalletTransactions.php (2 lines)
M		src/app/Http/Controllers/API/V4/WalletsController.php (79 lines)
M		src/app/Transaction.php (19 lines)
M		src/app/User.php (14 lines)
M		src/app/Wallet.php (10 lines)
M		src/phpstan.neon (3 lines)
M		src/resources/lang/en/transactions.php (11 lines)
M		src/resources/sass/app.scss (25 lines)
M		src/resources/vue/Wallet.vue (112 lines)
M		src/routes/api.php (1 line)
M		src/tests/Browser/Pages/Wallet.php (2 lines)
M		src/tests/Browser/WalletTest.php (76 lines)
A	M	src/tests/Feature/Controller/WalletsTest.php (150 lines)
M		src/tests/TestCaseTrait.php (69 lines)
A	M	src/tests/Unit/WalletTest.php (32 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3508	5df6db7		Jun 4 2020, 12:47 PM	★	★
Diff 2	3520	9b60624	- Top-up -> Payment	Jun 4 2020, 1:58 PM	★	★
Diff 3	3523	9b60624	rK10f2840186b808994f4bb3dda68a349723b47f63	Jun 4 2020, 1:59 PM	★	★