Page MenuHomePhorge
Feed Search

Jun 19 2020

machniak requested review of D1402: Aliases sharing.
Jun 19 2020, 8:22 AM

Jun 17 2020

machniak requested review of D1396: Fix created_at/updated_at on user settings added by UserObserver.
Jun 17 2020, 10:36 AM
machniak requested review of D1390: Added production seeders.
Jun 17 2020, 9:31 AM

Jun 15 2020

machniak committed rK01f9fcea44ce: Mobile UI fixes.
Jun 15 2020, 1:19 PM
machniak closed D1384: Mobile UI fixes.
Jun 15 2020, 1:19 PM
machniak committed rK61b980f766d8: Display a notice about the wallet state (Bifrost#T348752).
Jun 15 2020, 1:19 PM
machniak closed D1372: Display a notice about the wallet state (Bifrost#T348752).
Jun 15 2020, 1:19 PM
machniak committed rKb6a778523891: Add copyright and company details in the page footer.
Jun 15 2020, 1:19 PM
machniak closed D1378: Add copyright and company details in the page footer.
Jun 15 2020, 1:19 PM
machniak committed rK037514191beb: Fix transaction description for domain entitlements.
Jun 15 2020, 1:19 PM
machniak closed D1366: Fix transaction description for domain entitlements.
Jun 15 2020, 1:19 PM
machniak committed rKfbf3f75e27ea: Make sure we bill for entitlements that are deleted.
Jun 15 2020, 1:19 PM
machniak closed D1297: Make sure we bill for entitlements that are deleted.
Jun 15 2020, 1:19 PM
machniak updated the diff for D1378: Add copyright and company details in the page footer.
  • Hardcode copyright in the footer
Jun 15 2020, 1:09 PM
machniak updated the diff for D1384: Mobile UI fixes.
  • Add real favicon.ico
Jun 15 2020, 12:12 PM
machniak requested review of D1384: Mobile UI fixes.
Jun 15 2020, 11:03 AM

Jun 14 2020

machniak committed rK1e03ad3917a9: Bump js dependencies, fix linting issues.
Jun 14 2020, 6:34 AM

Jun 12 2020

machniak requested review of D1378: Add copyright and company details in the page footer.
Jun 12 2020, 10:19 AM
machniak updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Rollback transactions on exceptions
  • Performance optimization
Jun 12 2020, 9:01 AM
machniak added a comment to D1051: improve wallet layout.

Partially implemented in https://git.kolab.org/D1372 and we decided to not implement the costs overview table. So, I think this differential could be abandoned.

Jun 12 2020, 6:59 AM
machniak requested review of D1372: Display a notice about the wallet state (Bifrost#T348752).
Jun 12 2020, 6:55 AM

Jun 11 2020

machniak updated the summary of D1366: Fix transaction description for domain entitlements.
Jun 11 2020, 7:20 AM
machniak requested review of D1366: Fix transaction description for domain entitlements.
Jun 11 2020, 7:16 AM

Jun 10 2020

machniak committed rKc4818aadb932: Small css fix.
Jun 10 2020, 1:10 PM
machniak committed rK5b736c1c9b50: Fix font-size on small elements.
Jun 10 2020, 1:10 PM
machniak committed rK5819373d54ff: Improve error handling on signup welcome page.
Jun 10 2020, 1:10 PM
machniak committed rK98d3e8702b7e: Fix linting issues and a regression in browser tests.
Jun 10 2020, 10:31 AM
machniak committed rKf4537ed38a96: VAT on Receipts.
Jun 10 2020, 9:56 AM
machniak closed D1327: VAT on Receipts.
Jun 10 2020, 9:56 AM
machniak committed rK92c7f9f21811: Receipts UI.
Jun 10 2020, 9:56 AM
machniak closed D1348: Receipts UI.
Jun 10 2020, 9:56 AM
machniak updated the diff for D1348: Receipts UI.
  • Fix History tab after rabease
Jun 10 2020, 9:54 AM
machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
  • Rebase
Jun 10 2020, 9:45 AM
machniak committed rK90da82738276: Transaction log in admin UI.
Jun 10 2020, 9:41 AM
machniak closed D1360: Transaction log in admin UI.
Jun 10 2020, 9:41 AM
machniak committed rKda13578ce560: Wallet magic.
Jun 10 2020, 9:41 AM
machniak closed D1150: Wallet magic.
Jun 10 2020, 9:41 AM
machniak committed rK534d00000831: Cherry-picked contents from hkccp-import (authored by vanmeeuwen).
Jun 10 2020, 9:41 AM
machniak closed D1291: Cherry-picked contents from hkccp-import.
Jun 10 2020, 9:41 AM
machniak committed rK0481c595510a: Add plain text parts to email.
Jun 10 2020, 9:41 AM
machniak closed D1354: Add plain text parts to email.
Jun 10 2020, 9:41 AM
machniak added inline comments to D1360: Transaction log in admin UI.
Jun 10 2020, 8:58 AM
machniak updated the diff for D1360: Transaction log in admin UI.
  • Small code improvements
Jun 10 2020, 6:59 AM
machniak requested review of D1360: Transaction log in admin UI.
Jun 10 2020, 6:14 AM

Jun 9 2020

machniak committed rK7dc1e3fa2ee8: Limit number of records the test works with, code improvements.
Jun 9 2020, 9:12 AM
machniak requested review of D1354: Add plain text parts to email.
Jun 9 2020, 8:47 AM

Jun 8 2020

machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
Jun 8 2020, 10:03 AM
machniak requested review of D1348: Receipts UI.
Jun 8 2020, 6:49 AM

Jun 5 2020

machniak requested changes to D1150: Wallet magic.

@vanmeeuwen, I rebased, fixed obvious bugs and refactored the code so now we have Wallet::balanceLastsUntil() that we need tests for in tests/Feature/WalletTest::testBalanceLastsUntil().

Jun 5 2020, 11:47 AM
machniak updated the diff for D1150: Wallet magic.
  • Fix error due to missing use statements
  • Create Wallet::balanceLastsUntil()
Jun 5 2020, 11:44 AM
machniak added inline comments to D1297: Make sure we bill for entitlements that are deleted.
Jun 5 2020, 11:09 AM
machniak requested changes to D1297: Make sure we bill for entitlements that are deleted.

This learned us that an exception does not rollback uncommitted transactions. Here's a general fix for this issue:

--- a/src/app/Exceptions/Handler.php
+++ b/src/app/Exceptions/Handler.php
@@ -5,6 +5,7 @@ namespace App\Exceptions;
 use Exception;
 use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Support\Facades\DB;
Jun 5 2020, 10:50 AM
machniak committed rK35814db70a9c: Fix test failing when executed more than once.
Jun 5 2020, 7:34 AM
machniak accepted D1291: Cherry-picked contents from hkccp-import.

My comments to src/app/Domain.php were not addressed, but it's not critical.

Jun 5 2020, 7:01 AM
machniak updated the diff for D1327: VAT on Receipts.
  • Render fake receipt with VAT
Jun 5 2020, 6:26 AM

Jun 4 2020

machniak committed rK279da5dfbdc1: Fix regression, improve button labels.
Jun 4 2020, 2:22 PM
machniak requested review of D1327: VAT on Receipts.
Jun 4 2020, 1:07 PM
machniak committed rK10f2840186b8: Wallet history.
Jun 4 2020, 11:59 AM
machniak closed D1321: Wallet history.
Jun 4 2020, 11:59 AM
machniak updated the diff for D1321: Wallet history.
  • Top-up -> Payment
Jun 4 2020, 11:58 AM
machniak committed rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 10:53 AM
machniak closed D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 10:53 AM
machniak requested review of D1321: Wallet history.
Jun 4 2020, 10:47 AM
machniak committed rK5df6db72a947: Receipt document (html and pdf).
Jun 4 2020, 8:34 AM
machniak closed D1309: Receipt document (html and pdf).
Jun 4 2020, 8:33 AM
machniak added a comment to D1315: Return an empty body element for empty descriptions.

The spec. says Body is optional. https://docs.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascal/70161e94-3b50-4d20-8c4d-e3ca608f9dc8

Jun 4 2020, 7:37 AM

Jun 3 2020

machniak committed rKc4f6f1b8b280: Wallet charge: top-ups and notifications.
Jun 3 2020, 10:27 AM
machniak closed D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 10:26 AM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix typo
Jun 3 2020, 10:14 AM
machniak added inline comments to D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 7:41 AM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix Stripe auto-payment charge
  • Fix Mollie auto-payment
  • Add more tests
Jun 3 2020, 7:37 AM

Jun 1 2020

machniak updated the test plan for D1309: Receipt document (html and pdf).
Jun 1 2020, 8:43 AM
machniak requested review of D1309: Receipt document (html and pdf).
Jun 1 2020, 8:33 AM

May 29 2020

machniak retitled D1249: Wallet charge: top-ups and notifications from WIP: Wallet charge: top-ups and notifications
May 29 2020, 2:30 PM
machniak updated the summary of D1249: Wallet charge: top-ups and notifications.
May 29 2020, 2:30 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Update transaction log with payment description
  • Add wallet:mandate command to view/enable/disable auto-payment
  • Disabled mandate handling, test and fixed some flaky tests
May 29 2020, 2:29 PM
machniak updated the summary of D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
May 29 2020, 6:18 AM
machniak updated the diff for D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
  • Use transaction log
May 29 2020, 6:17 AM

May 28 2020

machniak planned changes to D1249: Wallet charge: top-ups and notifications.
May 28 2020, 10:58 AM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Add some payment notification jobs/emails
  • More on auto-top-ups and disabling mandates
  • Added tests for two jobs
  • Tests for Mollie wallet top-ups
  • Rename templates
  • Fix parse error
  • Stripe: Webhook fixes, more tests
  • Add todo
  • More webhook tests, send notifications for recurring payments only
  • Disable auto-payment mandate on failed payment
  • Add payment success/failure notification emails with tests
  • Payment mandate disabled notification
  • Fix typos
  • Small improvements
  • Improve wording
  • Add fakeRender() for all templates
May 28 2020, 10:57 AM
machniak requested changes to D1150: Wallet magic.

I think we'll need this code as a method on the Wallet object, as it will be needed also for UI. And we need a test. I don't understand the code, so I might get back to it later.

May 28 2020, 10:44 AM
machniak accepted D1102: An initial implementation of transactions..
May 28 2020, 10:07 AM
machniak committed rK9c680e8a7574: Support: Unsuspending/Suspending a user (Bifrost#T315890).
May 28 2020, 10:04 AM
machniak closed D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).
May 28 2020, 10:03 AM
machniak committed rKfac27dba481b: Add command to render mail templates.
May 28 2020, 10:03 AM
machniak closed D1303: Add command to render mail templates.
May 28 2020, 10:03 AM
machniak updated the diff for D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).

Rebased

May 28 2020, 10:02 AM
machniak added inline comments to D1297: Make sure we bill for entitlements that are deleted.
May 28 2020, 9:54 AM
machniak accepted D1219: Make the id for a user fillable.
May 28 2020, 9:37 AM
machniak requested changes to D1297: Make sure we bill for entitlements that are deleted.

Tests look good.

May 28 2020, 8:45 AM
machniak requested changes to D1291: Cherry-picked contents from hkccp-import.
May 28 2020, 8:28 AM
machniak committed rK7058be93faee: Fix test.
May 28 2020, 7:58 AM
machniak requested changes to D1219: Make the id for a user fillable.
May 28 2020, 7:21 AM
machniak requested changes to D1102: An initial implementation of transactions..

One last change request. Is it finished?

May 28 2020, 7:12 AM
machniak requested review of D1303: Add command to render mail templates.
May 28 2020, 6:53 AM

May 27 2020

machniak planned changes to D1249: Wallet charge: top-ups and notifications.
May 27 2020, 1:15 PM
machniak updated the summary of D1249: Wallet charge: top-ups and notifications.
May 27 2020, 1:15 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • More webhook tests, send notifications for recurring payments only
  • Disable auto-payment mandate on failed payment
  • Add payment success/failure notification emails with tests
  • Payment mandate disabled notification
  • Fix typos
  • Small improvements
  • Improve wording
May 27 2020, 1:14 PM
machniak added a comment to D1297: Make sure we bill for entitlements that are deleted.

Looking at the code in context of removing entitlements, I see we might not handle removing storage entitlements properly. We have to add some tests to tests/Feature/Controller/UsersTest::testUpdateEntitlements().

May 27 2020, 1:06 PM
machniak accepted D1285: Add a command db:ping and then use it.
May 27 2020, 10:40 AM