Page MenuHomekolab.org

Make the id for a user fillable
ClosedPublic

Authored by vanmeeuwen on Apr 21 2020, 5:12 PM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKe177a2f419e7: Make the id for a user fillable
Summary

Allow the unique identifier for a user account to be filled out for the purposes of import in transition, so as to preserve existing customer numbers.

Test Plan

None

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vanmeeuwen requested review of this revision.Apr 21 2020, 5:12 PM
vanmeeuwen created this revision.
machniak requested changes to this revision.May 28 2020, 9:21 AM
machniak added a subscriber: machniak.
machniak added inline comments.
src/app/Observers/UserObserver.php
35

As already mentioned in another place. I'd like this line out of the if statement. We mark all users with NEW+ACTIVE, I see no reason to make imported users not in sync with the rest.

This revision now requires changes to proceed.May 28 2020, 9:21 AM
vanmeeuwen updated this revision to Diff 3376.May 28 2020, 11:06 AM
  • Set new and active outside the user id test
  • Rebase on master
machniak accepted this revision.May 28 2020, 11:37 AM
This revision is now accepted and ready to land.May 28 2020, 11:37 AM
This revision was automatically updated to reflect the committed changes.