Page MenuHomePhorge

Make the id for a user fillable
ClosedPublic

Authored by vanmeeuwen on Apr 21 2020, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 7:52 AM
Unknown Object (File)
Mon, Mar 4, 2:41 PM
Unknown Object (File)
Jan 29 2024, 12:47 PM
Unknown Object (File)
Jan 20 2024, 12:48 AM
Unknown Object (File)
Jan 19 2024, 1:35 AM
Unknown Object (File)
Jan 18 2024, 6:33 AM
Unknown Object (File)
Jan 17 2024, 3:24 PM
Unknown Object (File)
Jan 17 2024, 6:36 AM
Subscribers
Restricted Project

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKe177a2f419e7: Make the id for a user fillable
Summary

Allow the unique identifier for a user account to be filled out for the purposes of import in transition, so as to preserve existing customer numbers.

Test Plan

None

Diff Detail

Repository
rK kolab
Branch
dev/transition/001-fillable-user-id
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29260
Build 10639: arc lint + arc unit

Event Timeline

vanmeeuwen created this revision.
machniak subscribed.
machniak added inline comments.
src/app/Observers/UserObserver.php
33

As already mentioned in another place. I'd like this line out of the if statement. We mark all users with NEW+ACTIVE, I see no reason to make imported users not in sync with the rest.

This revision now requires changes to proceed.May 28 2020, 9:21 AM
  • Set new and active outside the user id test
  • Rebase on master
This revision is now accepted and ready to land.May 28 2020, 11:37 AM
This revision was automatically updated to reflect the committed changes.