Page MenuHomekolab.org

Support: Unsuspending/Suspending a user (Bifrost#T315890)
ClosedPublic

Authored by machniak on May 14 2020, 4:32 PM.

Details

Summary

See the ticket for more info on the status

Test Plan

.phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.May 14 2020, 4:32 PM
machniak created this revision.
bohlender added inline comments.
src/resources/sass/_variables.scss
21–25

Having the main color also be the warning color makes the color coding somewhat useless. We can''t change our brand color so we might want to go yellow for the warning color instead.

@bohlender As you can see here I use btn-warning for the Subscribe/Unsubscribe button, which makes the button orange. I found that yellow didn't work well for buttons. Maybe we should just not use btn-warning at all. Please take a look at https://bifrost.kolabsystems.com/T315890#2637686 for possible improvement. I'd like to know your opinion.

vanmeeuwen requested changes to this revision.May 28 2020, 11:52 AM
vanmeeuwen added a subscriber: vanmeeuwen.

Needs rebasing for resources/sass/_variables.scss, then can be accepted I think.

This revision now requires changes to proceed.May 28 2020, 11:52 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 12:03 PM
This revision was automatically updated to reflect the committed changes.