Differential D1273

Support: Unsuspending/Suspending a user (Bifrost#T315890)
ClosedPublic
Actions

Authored by machniak on May 14 2020, 4:32 PM.

Details

Reviewers

vanmeeuwen

Group Reviewers

Restricted Project

Commits

rK9c680e8a7574: Support: Unsuspending/Suspending a user (Bifrost#T315890)

Summary

See the ticket for more info on the status

Test Plan

.phpunit

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.May 14 2020, 4:32 PM

machniak created this revision.

Harbormaster completed remote builds in B29407: Diff 3256.May 14 2020, 4:32 PM

bohlender subscribed.May 18 2020, 6:26 AM

bohlender added inline comments.

src/resources/sass/_variables.scss
21–25	Having the main color also be the warning color makes the color coding somewhat useless. We can''t change our brand color so we might want to go yellow for the warning color instead.

@bohlender As you can see here I use btn-warning for the Subscribe/Unsubscribe button, which makes the button orange. I found that yellow didn't work well for buttons. Maybe we should just not use btn-warning at all. Please take a look at https://bifrost.kolabsystems.com/T315890#2637686 for possible improvement. I'd like to know your opinion.