In D4085#49526, @machniak wrote:

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

What is it that currently doesn't work and afterwards works? (e.g. a kolab command that currently fails)

Added phpdocs

Unified the status attribute handling

some fixes

In D4076#49040, @machniak wrote:

As for the need for base_amount... We could get rid of it if we never support change of app.vat.mode on a working system. We could also store the mode instead. Also, having a calculated value that can be "directly" used for balance-related operations is handy. E.g. for Income chart we don't have to calculate the value in a sql query.

Instead of storing the vat with the payment I would store a foreign key to the vat entry with the payment (that said, I don't have a case where the current implementation doesn't work).

Two other points:

• Instead of storing the vat with the payment I would store a foreign key to the vat entry with the payment (that said, I don't have a case where the current implementation doesn't work).
• Not a blocker, but we'll likely require some UI changes as well for the payment process.

Fixed comments

New tokenizer that actually works but is incomplete yet.

I'm not a fan of this solution.

• For the immediate issue this seems like the simpler fix: https://git.kolab.org/D4069
• IMO this makes the seeder unnecessarily complicated
• This is not a solution for other cases where we'd overlay an existing file.

tbh, I'm not sure what the best approach is. We'll face the same issue when we e.g. include a configuration file in the overlay that also exists in the base, but I don't think we should limit ourselves to never overriding files that exist in the base.

In rKc99e8be93682770d130ddcf6c3f62d3f407cbfc1#558094, @machniak wrote:

@mollekopf, This will make my life harder. I can't make src/database/seeds a link to dir in config.demo/config.dev. Rewriting this file will make a problem to use git diff/git commit or whatever.

Merged after I included the changes in a package already.

Make it possible to completely disable the default folders mechanism

Regarding the configuration; I don't think it makes sense to attempt to stuff this into the environment, so I would rely on the overlay config mechanism and add the imap.php config file to the overlays where we want to change that configuration.

This has been shipped.

merged in master

Merged

Cleanup, also crate default folders if the inbox already exists (maybe autocreated by cyrus-imap?).

Create the folders authenticated as user so we can subscribe and set private metadata

This is what I've arrived at.

Made uri's configurable, some cleanup, centralized test account setup and cleanup.

I have pushed iRony 0.4.7 to Kolab:16. Don't know about the shortlogins, the code seems to still work in my tests, but I don't have an actual system that supports shortlogins that I could test against thunderbird.

Is this still a thing? Because I can't reproduce the issue.

more fixes

Test cleanup to work with test users.

Include the roundcube test and fixed some lint issues

Requires https://git.kolab.org/D3986

In T7097#99230, @machniak wrote:

I think the username canonification is done by kolab_auth plugin. So, maybe some problem with loading plugins/configuration.

The iRony patch is now available in https://obs.kolabsys.com/package/show/Kolab:16:Testing/iRony

I haven't really looked into the shortlogin issue yet, but at least for individual requests authenticated requests worked for me.
AFAIR the feature uses the username_domain roundcube config option to complete the login name if there is no domain part.

Thanks for the info.

According to tcpdump -s 0 -A 'tcp dst port 80' I'm indeed getting unauthenticated PROPFIND requests, but that can't work IMO, so I'm not sure what's going on.
If anybody could confirm that they also see unauthenticated requests, and confirm what they are seeing with the old iRony, that could help.

I'm trying to reproduce the thunderbird issue:

In T7097#98258, @sicherha wrote:

(Sorry about my tone in yesterday's last-night comment; I was a tad frustrated. I'd like to do what I can to help fix this as quickly as possible.)

In T7097#98246, @sicherha wrote:

It looks like the workaround (logging into iRony with the full email address) works fine with DAVx5 (on Android) but doesn't work with Kontact or Thunderbird.

Sigh... I was originally hoping to use my holiday to get Debian 11 support up & running, but there are too many fires to put out right now.

This is really not good and will break things. Please always raise the version number.

Indeed. Rule #1 for packagers: whenever the contents of a package change, bump its release number.
In my day job we use aptly, which refuses to accept an identically named .deb file with different contents, but I'm not aware that OBS supports that kind of check.

It's possible that we face additional incompatibilities, we have unfortunately rather poor test-coverage on these components.
But we do need the update to get to php8 support eventually.

I have now included the vobject compatibility fix and I'm not planning on downgrading the sabre dependencies again.
The updated iRony package is currently in Kolab:16:Testing, but I'm still fighting an obs issue that seems to somehow pull in the libkolabxml 1.3.0 update into Debian_10...

Just for clarification:

• On Debian 10 and Ubuntu 18.04 the php-kolabformat 1.3.0 update should indeed not be available
• With the 1.3.0 update the kolabformat.php file is expected to no longer exist, as it is not required by php and no longer generated in more recent swig variants.
• Kolab is not currently php 8 compatible (though we are working towards it).