Page MenuHomePhorge

PHP 8 fixes
ClosedPublic

Authored by mollekopf on Jan 24 2023, 1:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 6:34 AM
Unknown Object (File)
Fri, Nov 8, 12:00 AM
Unknown Object (File)
Fri, Nov 1, 6:34 AM
Unknown Object (File)
Thu, Oct 31, 8:38 PM
Unknown Object (File)
Wed, Oct 30, 12:27 PM
Unknown Object (File)
Thu, Oct 24, 11:31 PM
Unknown Object (File)
Thu, Oct 24, 11:31 PM
Unknown Object (File)
Sep 16 2024, 11:07 PM
Subscribers

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rACa9bf8b439f88: PHP 8 fixes

Diff Detail

Repository
rAC autoconf
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Jan 24 2023, 1:34 PM
machniak subscribed.
machniak added inline comments.
lib/Autodiscover.php
162

If $host is null str_replace() will throw a warning, no? Better to use empty string. Anyway, I don't see how is it possible to have $params[0] to be null/not-set?

169

This is not the same. What if the config is an empty string for some reason?

lib/AutodiscoverMicrosoft.php
166

Again, this is not the same.

This revision now requires changes to proceed.Jan 25 2023, 2:51 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Feb 24 2023, 4:26 PM
Closed by commit rACa9bf8b439f88: PHP 8 fixes (authored by mollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.