Page MenuHomekolab.org

PHP 8 fixes
Needs RevisionPublic

Authored by mollekopf on Tue, Jan 24, 1:34 PM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project

Diff Detail

Repository
rAC autoconf
Branch
dev/php8
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 41261
Build 16544: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Tue, Jan 24, 1:34 PM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Tue, Jan 24, 1:34 PM
machniak requested changes to this revision.Wed, Jan 25, 2:51 PM
machniak added a subscriber: machniak.
machniak added inline comments.
lib/Autodiscover.php
162

If $host is null str_replace() will throw a warning, no? Better to use empty string. Anyway, I don't see how is it possible to have $params[0] to be null/not-set?

169

This is not the same. What if the config is an empty string for some reason?

lib/AutodiscoverMicrosoft.php
166

Again, this is not the same.

This revision now requires changes to proceed.Wed, Jan 25, 2:51 PM