Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rACa9bf8b439f88: PHP 8 fixes
Diff Detail
Diff Detail
- Repository
- rAC autoconf
- Branch
- dev/php8
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 41261 Build 16544: arc lint + arc unit
Event Timeline
lib/Autodiscover.php | ||
---|---|---|
162 | If $host is null str_replace() will throw a warning, no? Better to use empty string. Anyway, I don't see how is it possible to have $params[0] to be null/not-set? | |
169 | This is not the same. What if the config is an empty string for some reason? | |
lib/AutodiscoverMicrosoft.php | ||
166 | Again, this is not the same. |