HomePhorge
Diffusion kolab c99e8be93682

composer fails if the directory for database/seeds doesn't exist, since it is…

Description

composer fails if the directory for database/seeds doesn't exist, since it is included in the class map appandage

Event Timeline

Jeroen van Meeuwen (Apheleia IT) <vanmeeuwen@apheleia-it.ch> committed rKc99e8be93682: composer fails if the directory for database/seeds doesn't exist, since it is… (authored by Jeroen van Meeuwen (Apheleia IT) <vanmeeuwen@apheleia-it.ch>).Feb 1 2023, 2:23 PM

@mollekopf, This will make my life harder. I can't make src/database/seeds a link to dir in config.demo/config.dev. Rewriting this file will make a problem to use git diff/git commit or whatever.

@mollekopf, This will make my life harder. I can't make src/database/seeds a link to dir in config.demo/config.dev. Rewriting this file will make a problem to use git diff/git commit or whatever.

Atm this only affects the kolabnow config I think, so our options are:

  • Add the dummy seeder to the kolabnow config
  • Ignore the changes via .gitignore
  • If it's just the directory that is the issue (not the seeder), then a .gitkeep file would be enough.

The most generic approach seems to me .gitignore/.gitkeep.

tbh, I'm not sure what the best approach is. We'll face the same issue when we e.g. include a configuration file in the overlay that also exists in the base, but I don't think we should limit ourselves to never overriding files that exist in the base.

Whenever there are such conflicts we have the issues that:

  • The modifications show up in git diff
  • A git pull is blocked due to modifications
  • A new file added to git will overwrite the one that was created by configure.sh (at least that's what I believe just happened to me).