Simplify setStatusAttribute
ClosedPublic
Actions

Authored by mollekopf on Feb 26 2023, 2:36 PM.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK0548b7bed7fe: Simplify setStatusAttribute
rK836eb4d0eaa1: Simplify setStatusAttribute
rK96af1b2d9ea8: Simplify setStatusAttribute
rKaa94bae5e8f2: cyrus imap murder setup
rKeab475088292: Simplify setStatusAttribute
rKfe964ec32a6b: Simplify setStatusAttribute

Summary

To me this is easier to understand, and I suppose it's theoretically the more performant solution (I doubt it matters).
Discard if you don't like it.

Diff Detail

Repository

rK kolab

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Feb 26 2023, 2:36 PM

mollekopf created this revision.

Harbormaster completed remote builds in B41693: Diff 11702.Feb 26 2023, 2:36 PM

mollekopf edited the summary of this revision. (Show Details)Feb 26 2023, 2:39 PM

mollekopf added a reviewer: Restricted Project.

I fine with it, but it would make sense to unify the similar code in App\Domain and App\Traits\StatusPropertyTrait.

Unified the status attribute handling

Harbormaster completed remote builds in B41846: Diff 11786.Sat, Mar 4, 3:48 PM

Added phpdocs

Harbormaster completed remote builds in B41855: Diff 11795.Sat, Mar 4, 4:11 PM

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

This revision now requires changes to proceed.Sun, Mar 5, 8:36 AM

In D4085#49526, @machniak wrote:

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

I'm not getting that in the codebase, just here. I suppose because the arc linting has no visibility on the trait.

machniak accepted this revision.Mon, Mar 6, 2:21 PM

This revision is now accepted and ready to land.Mon, Mar 6, 2:21 PM

This revision was landed with ongoing or failed builds.Tue, Mar 7, 9:42 PM

Closed by commit rK836eb4d0eaa1: Simplify setStatusAttribute (authored by Christian Mollekopf <mollekopf@apheleia-it.ch>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/app/Domain.php (33 lines)
M			src/app/Group.php (7 lines)
M			src/app/Resource.php (7 lines)
M			src/app/SharedFolder.php (7 lines)
M			src/app/Traits/StatusPropertyTrait.php (28 lines)
M			src/app/User.php (44 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11702	94496f8		Feb 26 2023, 2:36 PM	★	★
Diff 2	11786	97910c7	Unified the status attribute handling	Sat, Mar 4, 3:48 PM	★	★
Diff 3	11795	97910c7	Added phpdocs	Sat, Mar 4, 4:11 PM	★	★
Diff 4	11825	4bf9d9d	rK836eb4d0eaa1506e846491450425847f697a808d	Tue, Mar 7, 9:42 PM	★	★