Page MenuHomekolab.org

Simplify setStatusAttribute
ClosedPublic

Authored by mollekopf on Feb 26 2023, 2:36 PM.

Details

Summary

To me this is easier to understand, and I suppose it's theoretically the more performant solution (I doubt it matters).
Discard if you don't like it.

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Feb 26 2023, 2:36 PM
mollekopf created this revision.
mollekopf edited the summary of this revision. (Show Details)Feb 26 2023, 2:39 PM
mollekopf added a reviewer: Restricted Project.

I fine with it, but it would make sense to unify the similar code in App\Domain and App\Traits\StatusPropertyTrait.

mollekopf updated this revision to Diff 11786.Sat, Mar 4, 3:48 PM

Unified the status attribute handling

mollekopf updated this revision to Diff 11795.Sat, Mar 4, 4:11 PM

Added phpdocs

machniak requested changes to this revision.Sun, Mar 5, 8:36 AM

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

This revision now requires changes to proceed.Sun, Mar 5, 8:36 AM

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

I'm not getting that in the codebase, just here. I suppose because the arc linting has no visibility on the trait.

machniak accepted this revision.Mon, Mar 6, 2:21 PM
This revision is now accepted and ready to land.Mon, Mar 6, 2:21 PM
This revision was landed with ongoing or failed builds.Tue, Mar 7, 9:42 PM
Closed by commit rK836eb4d0eaa1: Simplify setStatusAttribute (authored by Christian Mollekopf <mollekopf@apheleia-it.ch>). · Explain Why
This revision was automatically updated to reflect the committed changes.