Page MenuHomePhorge
Differential D4085

Simplify setStatusAttribute
ClosedPublic
Actions

Authored by mollekopf on Feb 26 2023, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 29, 7:21 PM
Unknown Object (File)
Sat, Nov 25, 8:37 AM
Unknown Object (File)
Fri, Nov 24, 3:45 AM
Unknown Object (File)
Wed, Nov 15, 10:19 PM
Unknown Object (File)
Sun, Nov 12, 7:34 PM
Unknown Object (File)
Sat, Nov 11, 7:47 PM
Unknown Object (File)
Wed, Nov 8, 7:48 PM
Unknown Object (File)
Wed, Nov 8, 6:52 PM
View All 31 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKaa94bae5e8f2: cyrus imap murder setup
rK836eb4d0eaa1: Simplify setStatusAttribute
rK0548b7bed7fe: Simplify setStatusAttribute
rK96af1b2d9ea8: Simplify setStatusAttribute
rKeab475088292: Simplify setStatusAttribute
rKfe964ec32a6b: Simplify setStatusAttribute
Summary

To me this is easier to understand, and I suppose it's theoretically the more performant solution (I doubt it matters).
Discard if you don't like it.

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Feb 26 2023, 2:36 PM
mollekopf created this revision.
Harbormaster completed remote builds in B41693: Diff 11702.Feb 26 2023, 2:36 PM
mollekopf edited the summary of this revision. (Show Details)Feb 26 2023, 2:39 PM
mollekopf added a reviewer: Restricted Project.
machniak subscribed.Feb 27 2023, 2:47 PM

I fine with it, but it would make sense to unify the similar code in App\Domain and App\Traits\StatusPropertyTrait.

mollekopf updated this revision to Diff 11786.Mar 4 2023, 3:48 PM

Unified the status attribute handling

Harbormaster completed remote builds in B41846: Diff 11786.Mar 4 2023, 3:48 PM
mollekopf updated this revision to Diff 11795.Mar 4 2023, 4:11 PM

Added phpdocs

Harbormaster completed remote builds in B41855: Diff 11795.Mar 4 2023, 4:11 PM
machniak requested changes to this revision.Mar 5 2023, 8:36 AM

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

This revision now requires changes to proceed.Mar 5 2023, 8:36 AM
mollekopf added a comment.Mar 6 2023, 1:29 PM
In D4085#49526, @machniak wrote:

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

I'm not getting that in the codebase, just here. I suppose because the arc linting has no visibility on the trait.

machniak accepted this revision.Mar 6 2023, 2:21 PM
This revision is now accepted and ready to land.Mar 6 2023, 2:21 PM
This revision was landed with ongoing or failed builds.Mar 7 2023, 9:42 PM
Closed by commit rK836eb4d0eaa1: Simplify setStatusAttribute (authored by mollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
33 lines
7 lines
7 lines
7 lines
Traits/
28 lines
44 lines

Diff 11825

View Options

src/app/Domain.php

Loading...
View Options

src/app/Group.php

Loading...
View Options

src/app/Resource.php

Loading...
View Options

src/app/SharedFolder.php

Loading...
View Options

src/app/Traits/StatusPropertyTrait.php

Loading...
View Options

src/app/User.php

Loading...