Simplify setStatusAttribute
ClosedPublic
Actions

Authored by mollekopf on Feb 26 2023, 2:36 PM.

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rKaa94bae5e8f2: cyrus imap murder setup
rK836eb4d0eaa1: Simplify setStatusAttribute
rK0548b7bed7fe: Simplify setStatusAttribute
rK96af1b2d9ea8: Simplify setStatusAttribute
rKeab475088292: Simplify setStatusAttribute
rKfe964ec32a6b: Simplify setStatusAttribute

Summary

To me this is easier to understand, and I suppose it's theoretically the more performant solution (I doubt it matters).
Discard if you don't like it.

Diff Detail

Repository

rK kolab

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/app/Group.php:48	phpstan	Property App\Group::$allowed_states is never read, only written.
Error	src/app/Resource.php:49	phpstan	Property App\Resource::$allowed_states is never read, only written.
Error	src/app/SharedFolder.php:52	phpstan	Property App\SharedFolder::$allowed_states is never read, only written.
Error	src/app/User.php:65	phpstan	Property App\User::$allowed_states is never read, only written.

Unit

No Test Coverage

Build Status

Buildable 41855
Build 16802: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Feb 26 2023, 2:36 PM

mollekopf created this revision.

Harbormaster completed remote builds in B41693: Diff 11702.Feb 26 2023, 2:36 PM

mollekopf edited the summary of this revision. (Show Details)Feb 26 2023, 2:39 PM

mollekopf added a reviewer: Restricted Project.

I fine with it, but it would make sense to unify the similar code in App\Domain and App\Traits\StatusPropertyTrait.

Unified the status attribute handling

Harbormaster completed remote builds in B41846: Diff 11786.Mar 4 2023, 3:48 PM

Added phpdocs

Harbormaster completed remote builds in B41855: Diff 11795.Mar 4 2023, 4:11 PM

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

This revision now requires changes to proceed.Mar 5 2023, 8:36 AM

In D4085#49526, @machniak wrote:

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

I'm not getting that in the codebase, just here. I suppose because the arc linting has no visibility on the trait.

machniak accepted this revision.Mar 6 2023, 2:21 PM

This revision is now accepted and ready to land.Mar 6 2023, 2:21 PM

This revision was landed with ongoing or failed builds.Mar 7 2023, 9:42 PM

Closed by commit rK836eb4d0eaa1: Simplify setStatusAttribute (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.