To me this is easier to understand, and I suppose it's theoretically the more performant solution (I doubt it matters).
Discard if you don't like it.
Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rKaa94bae5e8f2: cyrus imap murder setup
rK836eb4d0eaa1: Simplify setStatusAttribute
rK0548b7bed7fe: Simplify setStatusAttribute
rK96af1b2d9ea8: Simplify setStatusAttribute
rKeab475088292: Simplify setStatusAttribute
rKfe964ec32a6b: Simplify setStatusAttribute
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Errors Severity Location Code Message Error src/app/Group.php:48 phpstan Property App\Group::$allowed_states is never read, only written. Error src/app/Resource.php:49 phpstan Property App\Resource::$allowed_states is never read, only written. Error src/app/SharedFolder.php:52 phpstan Property App\SharedFolder::$allowed_states is never read, only written. Error src/app/User.php:65 phpstan Property App\User::$allowed_states is never read, only written. - Unit
No Test Coverage - Build Status
Buildable 41855 Build 16802: arc lint + arc unit
Event Timeline
Comment Actions
I fine with it, but it would make sense to unify the similar code in App\Domain and App\Traits\StatusPropertyTrait.
Comment Actions
Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.
Comment Actions
I'm not getting that in the codebase, just here. I suppose because the arc linting has no visibility on the trait.