Page MenuHomePhorge

Simplify setStatusAttribute
ClosedPublic

Authored by mollekopf on Feb 26 2023, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 4:16 PM
Unknown Object (File)
Feb 22 2024, 5:01 PM
Unknown Object (File)
Feb 11 2024, 7:32 AM
Unknown Object (File)
Jan 23 2024, 6:51 PM
Unknown Object (File)
Jan 23 2024, 6:06 PM
Unknown Object (File)
Jan 19 2024, 5:38 PM
Unknown Object (File)
Jan 16 2024, 5:55 PM
Unknown Object (File)
Dec 21 2023, 11:24 AM
Subscribers

Details

Summary

To me this is easier to understand, and I suppose it's theoretically the more performant solution (I doubt it matters).
Discard if you don't like it.

Diff Detail

Repository
rK kolab
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/app/Group.php:47phpstanProperty App\Group::$allowed_states is never read, only written.
Errorsrc/app/Resource.php:48phpstanProperty App\Resource::$allowed_states is never read, only written.
Errorsrc/app/SharedFolder.php:51phpstanProperty App\SharedFolder::$allowed_states is never read, only written.
Errorsrc/app/User.php:64phpstanProperty App\User::$allowed_states is never read, only written.
Unit
No Test Coverage
Build Status
Buildable 41846
Build 16793: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.

I fine with it, but it would make sense to unify the similar code in App\Domain and App\Traits\StatusPropertyTrait.

Unified the status attribute handling

machniak requested changes to this revision.Mar 5 2023, 8:36 AM

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

This revision now requires changes to proceed.Mar 5 2023, 8:36 AM

Nice. We have to silence the linting error: Property App\SharedFolder::$allowed_states is never read, only written.

I'm not getting that in the codebase, just here. I suppose because the arc linting has no visibility on the trait.

This revision is now accepted and ready to land.Mar 6 2023, 2:21 PM
This revision was landed with ongoing or failed builds.Mar 7 2023, 9:42 PM
This revision was automatically updated to reflect the committed changes.