Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/seeders
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 41506 Build 16645: arc lint + arc unit
Event Timeline
Comment Actions
There's pros and cons with this approach:
- no need for env-specific DatabaseSeeder class
- seeders are required to use Database\Seeds namespace, and class names must be the same as the filename (after removing XX- prefix and .php suffix). It could be done with anonymous classes, but the command output would be uglier.
Comment Actions
I'm not a fan of this solution.
- For the immediate issue this seems like the simpler fix: https://git.kolab.org/D4069
- IMO this makes the seeder unnecessarily complicated
- This is not a solution for other cases where we'd overlay an existing file.