Differential D4063

Universal Database Seeder
AbandonedPublic
Actions

Authored by machniak on Feb 3 2023, 12:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 21, 5:06 PM

	Unknown Object (File)
	Sun, Apr 21, 5:06 PM

	Unknown Object (File)
	Sat, Apr 20, 5:58 AM

	Unknown Object (File)
	Wed, Apr 17, 11:28 PM

	Unknown Object (File)
	Wed, Apr 17, 10:07 AM

	Unknown Object (File)
	Sat, Apr 13, 8:25 PM

	Unknown Object (File)
	Wed, Apr 3, 7:45 PM

	Unknown Object (File)
	Fri, Mar 29, 7:50 AM

View All 46 Files

Subscribers

Restricted Project

Details

Reviewers

None

Group Reviewers

Restricted Project

Diff Detail

Repository

Branch

dev/seeders

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 41506
Build 16645: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Feb 3 2023, 12:58 PM

machniak created this revision.

Harbormaster completed remote builds in B41506: Diff 11590.Feb 3 2023, 12:58 PM

There's pros and cons with this approach:

no need for env-specific DatabaseSeeder class
seeders are required to use Database\Seeds namespace, and class names must be the same as the filename (after removing XX- prefix and .php suffix). It could be done with anonymous classes, but the command output would be uglier.

I'm not a fan of this solution.

For the immediate issue this seems like the simpler fix: https://git.kolab.org/D4069
IMO this makes the seeder unnecessarily complicated
This is not a solution for other cases where we'd overlay an existing file.

Ok, let's go with D4069: Revert composer failure fix but preserve the directory.

Revision Contents
Changeset List

Path

Size

config.demo/

src/

database/

seeds/

	10-IPNetsSeeder.php
	IP4NetSeeder.php

2 lines

	10-PassportSeeder.php
	PassportSeeder.php

34 lines

	10-TenantSeeder.php
	TenantSeeder.php

37 lines

	20-DiscountSeeder.php
	DiscountSeeder.php

58 lines

	20-DomainSeeder.php
	DomainSeeder.php

86 lines

	20-PowerDNSSeeder.php
	PowerDNSSeeder.php

43 lines

	20-SkuSeeder.php
	SkuSeeder.php

250 lines

	40-PackageSeeder.php
	PackageSeeder.php

166 lines

	50-PlanSeeder.php
	PlanSeeder.php

145 lines

	60-UserSeeder.php
	UserSeeder.php

246 lines

	70-MeetRoomSeeder.php
	MeetRoomSeeder.php

39 lines

	70-ResourceSeeder.php
	ResourceSeeder.php

33 lines

	70-SharedFolderSeeder.php
	SharedFolderSeeder.php

35 lines

DatabaseSeeder.php

DiscountSeeder.php

DomainSeeder.php

IP4NetSeeder.php

MeetRoomSeeder.php

PackageSeeder.php

PassportSeeder.php

PowerDNSSeeder.php

ResourceSeeder.php

SharedFolderSeeder.php

TenantSeeder.php

config.prod/

src/

database/

seeds/

	10-PassportSeeder.php
	PassportSeeder.php

34 lines

	10-PowerDNSSeeder.php
	PowerDNSSeeder.php

23 lines

	20-SkuSeeder.php
	SkuSeeder.php

172 lines

	30-AdminSeeder.php
	AdminSeeder.php

86 lines

AdminSeeder.php

DatabaseSeeder.php

PassportSeeder.php

PowerDNSSeeder.php

src/

1 line

database/

seeds/

DatabaseSeeder.php

include/

DatabaseSeeder.php

29 lines

Diff 11590

config.demo/src/database/seeds/10-IPNetsSeeder.php

Loading...

config.demo/src/database/seeds/10-PassportSeeder.php

Loading...

config.demo/src/database/seeds/10-TenantSeeder.php

Loading...

config.demo/src/database/seeds/20-DiscountSeeder.php

Loading...

config.demo/src/database/seeds/20-DomainSeeder.php

Loading...

config.demo/src/database/seeds/20-PowerDNSSeeder.php

Loading...

config.demo/src/database/seeds/20-SkuSeeder.php

Loading...

config.demo/src/database/seeds/40-PackageSeeder.php

Loading...

config.demo/src/database/seeds/50-PlanSeeder.php

Loading...

config.demo/src/database/seeds/60-UserSeeder.php

Loading...

config.demo/src/database/seeds/70-MeetRoomSeeder.php

Loading...

config.demo/src/database/seeds/70-ResourceSeeder.php

Loading...

config.demo/src/database/seeds/70-SharedFolderSeeder.php

Loading...

config.demo/src/database/seeds/DatabaseSeeder.php

Loading...

config.demo/src/database/seeds/DiscountSeeder.php

Loading...

config.demo/src/database/seeds/DomainSeeder.php

Loading...

config.demo/src/database/seeds/IP4NetSeeder.php

Loading...

config.demo/src/database/seeds/MeetRoomSeeder.php

Loading...

config.demo/src/database/seeds/PackageSeeder.php

Loading...

config.demo/src/database/seeds/PassportSeeder.php

Loading...

config.demo/src/database/seeds/PlanSeeder.php

Loading...

config.demo/src/database/seeds/PowerDNSSeeder.php

Loading...

config.demo/src/database/seeds/ResourceSeeder.php

Loading...

config.demo/src/database/seeds/SharedFolderSeeder.php

Loading...

config.demo/src/database/seeds/SkuSeeder.php

Loading...

config.demo/src/database/seeds/TenantSeeder.php

Loading...

config.demo/src/database/seeds/UserSeeder.php

Loading...

config.prod/src/database/seeds/10-PassportSeeder.php

Loading...

config.prod/src/database/seeds/10-PowerDNSSeeder.php

Loading...

config.prod/src/database/seeds/20-SkuSeeder.php

Loading...

config.prod/src/database/seeds/30-AdminSeeder.php

Loading...

config.prod/src/database/seeds/AdminSeeder.php

Loading...

config.prod/src/database/seeds/DatabaseSeeder.php

Loading...

config.prod/src/database/seeds/PassportSeeder.php

Loading...

config.prod/src/database/seeds/PowerDNSSeeder.php

Loading...

config.prod/src/database/seeds/SkuSeeder.php

Loading...

src/composer.json

Loading...

src/database/seeds/DatabaseSeeder.php

Loading...

src/include/DatabaseSeeder.php

Loading...