Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rKb8e5e644a04e: Create default folders in imap
rK4674742e8f04: Create default folders in imap
rKd7f345fbad5f: Create default folders in imap
rKd16279cce742: Create default folders in imap
rK1494a9cfb7b7: Create default folders in imap
rK333041595a4b: Create default folders in imap
Diff Detail
- Repository
- rK kolab
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Create the folders authenticated as user so we can subscribe and set private metadata
Cleanup, also crate default folders if the inbox already exists (maybe autocreated by cyrus-imap?).
Regarding the configuration; I don't think it makes sense to attempt to stuff this into the environment, so I would rely on the overlay config mechanism and add the imap.php config file to the overlays where we want to change that configuration.
The default set of folders will not make always sense. How do you disable the feature, or redefine the set? Replacing the while imap.php file is not the best option.
| src/app/Backends/IMAP.php | ||
|---|---|---|
| 470 | I'd remove that info() call. | |
| 538 | Missing parameters. | |
| 540 | @return without s. | |
| 550 | "Failed to create mailbox Trash" might not be very helpful in log if there's no context. I'd remove this error() call. Exception should get logged with some context. | |
By default, you should also create the Archive folder.
Currently, it's only created when you attempt to Archive a folder in the webclient.
We either use the same set of default folders as in https://git.kolab.org/diffusion/P/browse/master/conf/kolab.conf$65 or make the list empty by default.