Page MenuHomePhorge

Create default folders in imap
ClosedPublic

Authored by mollekopf on Jan 31 2023, 2:53 PM.
Tags
None
Referenced Files
F11589669: D4039.id11542.diff
Thu, Mar 28, 11:56 PM
Unknown Object (File)
Thu, Mar 7, 8:58 PM
Unknown Object (File)
Feb 15 2024, 10:24 AM
Unknown Object (File)
Feb 8 2024, 5:15 PM
Unknown Object (File)
Feb 7 2024, 6:44 PM
Unknown Object (File)
Jan 30 2024, 3:38 AM
Unknown Object (File)
Jan 18 2024, 4:09 PM
Unknown Object (File)
Jan 18 2024, 12:31 AM

Diff Detail

Repository
rK kolab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41545
Build 16663: arc lint + arc unit

Event Timeline

mollekopf created this revision.

Create the folders authenticated as user so we can subscribe and set private metadata

mollekopf added a reviewer: Restricted Project.Jan 31 2023, 4:47 PM

Cleanup, also crate default folders if the inbox already exists (maybe autocreated by cyrus-imap?).

Regarding the configuration; I don't think it makes sense to attempt to stuff this into the environment, so I would rely on the overlay config mechanism and add the imap.php config file to the overlays where we want to change that configuration.

Make it possible to completely disable the default folders mechanism

Harbormaster completed remote builds in B41380: Diff 11536.
Harbormaster completed remote builds in B41383: Diff 11542.
Harbormaster completed remote builds in B41395: Diff 11554.
machniak requested changes to this revision.Feb 6 2023, 3:35 PM
machniak subscribed.

The default set of folders will not make always sense. How do you disable the feature, or redefine the set? Replacing the while imap.php file is not the best option.

src/app/Backends/IMAP.php
470

I'd remove that info() call.

538

Missing parameters.

540

@return without s.

550

"Failed to create mailbox Trash" might not be very helpful in log if there's no context. I'd remove this error() call. Exception should get logged with some context.

This revision now requires changes to proceed.Feb 6 2023, 3:35 PM

By default, you should also create the Archive folder.

Currently, it's only created when you attempt to Archive a folder in the webclient.

mollekopf marked 3 inline comments as done.

Fixed comments

We either use the same set of default folders as in https://git.kolab.org/diffusion/P/browse/master/conf/kolab.conf$65 or make the list empty by default.

This revision now requires changes to proceed.Feb 27 2023, 3:02 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Mar 4 2023, 3:31 PM
This revision was automatically updated to reflect the committed changes.