Page MenuHomePhorge
Feed Advanced Search

Jan 25 2022

machniak requested review of D3319: Password Policy.
Jan 25 2022, 11:59 AM
machniak requested changes to D3023: bin/quickstart.sh enhancements.
Jan 25 2022, 10:36 AM

Jan 21 2022

machniak requested review of D3313: Add more "beta" badges in the UI.
Jan 21 2022, 10:27 AM
machniak updated the diff for D3307: CLI tools for shared folders.
  • Add --acl option
Jan 21 2022, 10:00 AM

Jan 19 2022

machniak requested review of D3307: CLI tools for shared folders.
Jan 19 2022, 10:09 AM

Jan 18 2022

machniak updated the diff for D3301: Password reset link.
  • Merge branch 'master' into dev/password-link
Jan 18 2022, 12:52 PM
machniak committed rK63741372535a: Fix flaky tests (authored by machniak).
Fix flaky tests
Jan 18 2022, 11:59 AM
machniak committed rK4584eed7db8a: Fix browser test regressions (authored by machniak).
Fix browser test regressions
Jan 18 2022, 11:32 AM

Jan 14 2022

machniak updated the diff for D3301: Password reset link.
  • Fixes requsted in the diff, set expiration time to 24h
Jan 14 2022, 3:28 PM
machniak updated the diff for D3301: Password reset link.
  • Merge branch 'master' into dev/password-link
Jan 14 2022, 2:51 PM
machniak committed rK3d7439962063: StatusPropertyTrait, and some more code de-duplication (authored by machniak).
StatusPropertyTrait, and some more code de-duplication
Jan 14 2022, 2:50 PM
machniak closed D3196: StatusPropertyTrait, and some more code de-duplication.
Jan 14 2022, 2:50 PM
machniak requested review of D3301: Password reset link.
Jan 14 2022, 2:49 PM

Jan 13 2022

machniak committed rRPK24d2633ff6e4: Calendar: Fix attaching files on event creation (authored by machniak).
Calendar: Fix attaching files on event creation
Jan 13 2022, 12:13 PM

Jan 12 2022

machniak accepted D2984: Proxy authorization for irony/syncroton.
Jan 12 2022, 7:55 AM
machniak added a comment to D3289: .arclint config.

I'd prefer .arc folder instead of phabricator.

Jan 12 2022, 7:51 AM
machniak requested changes to D3280: roundcube config changes.
Jan 12 2022, 7:49 AM

Jan 11 2022

machniak accepted D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 11 2022, 9:57 AM

Jan 10 2022

machniak committed rS5838cfd4a733: Require zend-json (authored by machniak).
Require zend-json
Jan 10 2022, 4:50 PM
machniak committed rKa9ad1196af9c: Kolab3 migration tool (authored by machniak).
Kolab3 migration tool
Jan 10 2022, 11:31 AM
machniak closed D3184: Kolab3 migration tool.
Jan 10 2022, 11:31 AM
machniak committed rKed984b2e359d: Split client javascript code into core+unauthenticated and authenticated, the… (authored by machniak).
Split client javascript code into core+unauthenticated and authenticated, the…
Jan 10 2022, 11:28 AM
machniak closed D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.
Jan 10 2022, 11:28 AM
machniak updated the diff for D3184: Kolab3 migration tool.
  • Drop temp table
Jan 10 2022, 11:27 AM
machniak added a comment to D3196: StatusPropertyTrait, and some more code de-duplication.

Since traits can't define constants yet, one possible improvement would be to define interfaces, and use them together with trait(s). And we could unify the constant values to be the same for all objects at some point too. Still, User has STATUS_DEGRADED, Domain has STATUS_CONFIRMED, etc. So, for example:

interface StatusSuspendedInterface {
    const STATUS_SUSPENDED = 4;
    function isSuspended();
    function suspend();
    function unsuspend();
}

For now I prefer to not define interfaces and use my simple trait with the common status functionality.

Jan 10 2022, 11:12 AM
machniak requested changes to D2984: Proxy authorization for irony/syncroton.
Jan 10 2022, 9:48 AM
machniak requested changes to D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 10 2022, 9:08 AM

Jan 7 2022

machniak requested review of D3196: StatusPropertyTrait, and some more code de-duplication.
Jan 7 2022, 2:57 PM

Jan 6 2022

machniak updated the diff for D3184: Kolab3 migration tool.
  • Small fixes
Jan 6 2022, 2:18 PM
machniak updated the diff for D3184: Kolab3 migration tool.
  • Errors/warnings, more tests
Jan 6 2022, 1:57 PM
machniak added a comment to T6805: Port pykolab to Python 3.

Could you create differential(s)? It should be possible to do this having patches via https://git.kolab.org/differential/diff/create/. Or just by using arc diff on your git clone.

Jan 6 2022, 11:05 AM · Architecture & Design

Jan 5 2022

machniak updated the diff for D3184: Kolab3 migration tool.
  • Solve FIXMEs
  • Groups import
  • Resources import
  • Move createProgressBar() to App\Console\Command
  • Check domain existence
  • Small fixes
Jan 5 2022, 3:59 PM
machniak requested review of D3184: Kolab3 migration tool.
Jan 5 2022, 1:28 PM

Jan 3 2022

machniak committed rKba18be4fbe73: Add some missing indices in signup_codes table (authored by machniak).
Add some missing indices in signup_codes table
Jan 3 2022, 11:42 AM
machniak closed D3179: Add some missing indices in signup_codes table.
Jan 3 2022, 11:42 AM
machniak committed rK48be1755584c: Get rid of keyType=bigint, and make the language cookie "secure" (authored by machniak).
Get rid of keyType=bigint, and make the language cookie "secure"
Jan 3 2022, 11:42 AM
machniak closed D3173: Get rid of keyType=bigint, and make the language cookie "secure".
Jan 3 2022, 11:42 AM
machniak committed rK768383ccce5a: Use domain_root_dn() for all kind of objects consistently (authored by machniak).
Use domain_root_dn() for all kind of objects consistently
Jan 3 2022, 11:42 AM
machniak closed D3155: Use domain_root_dn() for all kind of objects consistently.
Jan 3 2022, 11:42 AM
machniak requested review of D3179: Add some missing indices in signup_codes table.
Jan 3 2022, 11:25 AM
machniak committed rK713a15b5dabc: Fix phpstan error (authored by machniak).
Fix phpstan error
Jan 3 2022, 11:04 AM
machniak updated the diff for D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.
  • Small css fixes
Jan 3 2022, 10:51 AM

Dec 31 2021

machniak updated the diff for D3173: Get rid of keyType=bigint, and make the language cookie "secure".
  • Fix flaky test
Dec 31 2021, 2:00 PM
machniak requested review of D3173: Get rid of keyType=bigint, and make the language cookie "secure".
Dec 31 2021, 1:49 PM
machniak accepted D3161: Implement Kolab 4 rate limitations.
Dec 31 2021, 1:04 PM
machniak requested review of D3167: Content Security Policy headers.
Dec 31 2021, 12:34 PM
machniak requested changes to D3161: Implement Kolab 4 rate limitations.
Dec 31 2021, 11:47 AM
machniak added inline comments to D3161: Implement Kolab 4 rate limitations.
Dec 31 2021, 11:11 AM
machniak requested changes to D3161: Implement Kolab 4 rate limitations.
Dec 31 2021, 10:21 AM

Dec 27 2021

machniak requested review of D3155: Use domain_root_dn() for all kind of objects consistently.
Dec 27 2021, 12:35 PM
machniak committed rKa5685122028d: Fix PowerDNS test regression (authored by machniak).
Fix PowerDNS test regression
Dec 27 2021, 10:59 AM
machniak updated the summary of D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.
Dec 27 2021, 10:35 AM
machniak committed rK8e8e5d3c0df8: Fix user DN generation (authored by machniak).
Fix user DN generation
Dec 27 2021, 10:32 AM
machniak updated the diff for D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.
  • Merge branch 'master' into dev/split-client
Dec 27 2021, 9:46 AM

Dec 24 2021

machniak requested review of D3149: Signup limits.
Dec 24 2021, 10:53 AM

Dec 23 2021

machniak accepted D3143: Report resources as AttendeeType=3.
Dec 23 2021, 9:53 AM
machniak added inline comments to D3137: Enhance protections in signup in two ways;.
Dec 23 2021, 9:52 AM

Dec 22 2021

machniak requested changes to D3143: Report resources as AttendeeType=3.
Dec 22 2021, 7:25 PM
machniak requested changes to D3137: Enhance protections in signup in two ways;.
Dec 22 2021, 11:07 AM

Dec 21 2021

machniak committed rRPK2dc22ac017fc: kolab_2fa: Allow kolab_auth'enticated admins to change user's 2FA settings… (authored by machniak).
kolab_2fa: Allow kolab_auth'enticated admins to change user's 2FA settings…
Dec 21 2021, 11:06 AM

Dec 17 2021

machniak committed rK386cd1df4ee1: Fix linting errors (authored by machniak).
Fix linting errors
Dec 17 2021, 3:18 PM
machniak committed rK928f04d1f017: De-duplicate *statusText() and *statusClass() (authored by machniak).
De-duplicate *statusText() and *statusClass()
Dec 17 2021, 2:24 PM
machniak committed rKad947512d7ff: Degraded accounts (authored by machniak).
Degraded accounts
Dec 17 2021, 1:31 PM
machniak closed D2371: Degraded accounts.
Dec 17 2021, 1:31 PM
machniak updated the diff for D2371: Degraded accounts.
  • Merge branch 'master' into dev/status-degraded
  • Hide more create buttons
  • Fix test regression
  • Fix regression
  • Cleanup
Dec 17 2021, 1:25 PM
machniak accepted D3086: Avoid relying on the sender for REPLY attendee matching..
Dec 17 2021, 1:10 PM
machniak accepted D3083: Resource invitation enhancements.
Dec 17 2021, 1:07 PM
machniak committed rK37a96aac7041: Unify beta SKUs (authored by machniak).
Unify beta SKUs
Dec 17 2021, 11:35 AM
machniak closed D3128: Unify beta SKUs.
Dec 17 2021, 11:35 AM
machniak committed rKb544e3cce14c: Unify API controllers, code de-duplication (authored by machniak).
Unify API controllers, code de-duplication
Dec 17 2021, 11:35 AM
machniak closed D3122: Unify API controllers, code de-duplication.
Dec 17 2021, 11:35 AM
machniak committed rKf4b93aa12543: Unify entitleables' events handling (authored by machniak).
Unify entitleables' events handling
Dec 17 2021, 11:35 AM
machniak closed D3116: Unify entitleables' events handling.
Dec 17 2021, 11:35 AM
machniak committed rK424bb0c634f5: Unify code of various object listing methods (authored by machniak).
Unify code of various object listing methods
Dec 17 2021, 11:35 AM
machniak closed D3110: Unify code of various object listing methods.
Dec 17 2021, 11:35 AM
machniak committed rK1b8a80907329: Move some common code to the EntitleableTrait (authored by machniak).
Move some common code to the EntitleableTrait
Dec 17 2021, 11:35 AM
machniak closed D3104: Move some common code to the EntitleableTrait.
Dec 17 2021, 11:35 AM
machniak committed rKbe233bed49bc: Set ACL for the resource owner (authored by machniak).
Set ACL for the resource owner
Dec 17 2021, 11:35 AM
machniak closed D3098: Set ACL for the resource owner.
Dec 17 2021, 11:35 AM
machniak committed rKa7cd372f8179: Shared folders (authored by machniak).
Shared folders
Dec 17 2021, 11:35 AM
machniak closed D3071: Shared folders.
Dec 17 2021, 11:35 AM
machniak committed rRPKea78b1c2df4f: Display original time and timezone in iTip info box (authored by machniak).
Display original time and timezone in iTip info box
Dec 17 2021, 11:28 AM

Dec 16 2021

machniak committed rKeb3ad856c681: Fix flaky test (authored by machniak).
Fix flaky test
Dec 16 2021, 2:56 PM
machniak accepted D3077: Implement ACT_STORE_AND_NOTIFY policy for resources, add webmail url to the notification body.
Dec 16 2021, 2:00 PM
machniak requested review of D3128: Unify beta SKUs.
Dec 16 2021, 1:45 PM

Dec 15 2021

machniak updated the diff for D3110: Unify code of various object listing methods.
  • Fix regression in User::domains()
Dec 15 2021, 11:19 AM
machniak requested review of D3122: Unify API controllers, code de-duplication.
Dec 15 2021, 10:42 AM

Dec 13 2021

machniak requested review of D3116: Unify entitleables' events handling.
Dec 13 2021, 3:24 PM

Dec 10 2021

machniak updated the diff for D3071: Shared folders.
  • Add tests for resource's jobs
  • Add tests for shared folders' jobs
Dec 10 2021, 1:55 PM
machniak requested review of D3110: Unify code of various object listing methods.
Dec 10 2021, 10:53 AM

Dec 9 2021

machniak requested review of D3104: Move some common code to the EntitleableTrait.
Dec 9 2021, 12:34 PM
machniak requested review of D3098: Set ACL for the resource owner.
Dec 9 2021, 10:01 AM

Dec 8 2021

machniak requested changes to D3086: Avoid relying on the sender for REPLY attendee matching..
Dec 8 2021, 11:29 AM
machniak requested changes to D3083: Resource invitation enhancements.
Dec 8 2021, 11:04 AM
machniak requested changes to D3077: Implement ACT_STORE_AND_NOTIFY policy for resources, add webmail url to the notification body.
# nosetests tests/unit/test-011-wallace_resources.py
.....E
======================================================================
ERROR: test_007_accept_reservation_request_store_and_notify
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/utils.py", line 191, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/root/kolab-pykolab/tests/unit/test-011-wallace_resources.py", line 274, in test_007_accept_reservation_request_store_and_notify
    self.assertEqual("resource-collection-car@example.org", self.smtplog[1][0])
IndexError: list index out of range

it should be self.smtplog[0]0] in line 274 and self.smtplog[0][1] in line 276.

Dec 8 2021, 10:38 AM

Dec 7 2021

machniak requested review of D3092: Implement fetching free-busy data from an Exchange server via Microsoft Graph.
Dec 7 2021, 2:02 PM
machniak added a comment to T6610: style.css and files_api.js only http not https.

You can pass a full url there.

Dec 7 2021, 10:17 AM · Bug Reports

Dec 3 2021

machniak updated the diff for D3071: Shared folders.
  • Re-title shared_folders SKU to shared-folders for consistency with others
  • Make phpstan happy
  • Make phpstan happy, now we're green
Dec 3 2021, 2:51 PM
machniak updated the diff for D3071: Shared folders.
  • Fix regression
  • Complete imap tests
  • Cleanup and more tests
Dec 3 2021, 12:36 PM
machniak requested review of D3071: Shared folders.
Dec 3 2021, 9:55 AM