Page MenuHomePhorge

Resource invitation enhancements

Authored by mollekopf on Dec 6 2021, 10:30 AM.
Referenced Files
Unknown Object (File)
Sat, Nov 25, 1:54 PM
Unknown Object (File)
Wed, Nov 8, 9:40 AM
Unknown Object (File)
Tue, Nov 7, 1:01 AM
Unknown Object (File)
Fri, Nov 3, 10:54 PM
Unknown Object (File)
Thu, Nov 2, 10:39 AM
Unknown Object (File)
Oct 26 2023, 7:12 PM
Unknown Object (File)
Oct 22 2023, 11:59 AM
Unknown Object (File)
Oct 5 2023, 2:49 AM


  • Display RSVP buttons for resource owners.
  • Adapted mail texts to make sense for new resource invitations.
  • When generating a REPLY, keep track if we are responding on behalf of a resource, and set SENT-BY accordingly

Diff Detail

rRPK roundcubemail-plugins-kolab
Lint Not Applicable
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Dec 6 2021, 10:36 AM
machniak subscribed.
machniak added inline comments.

You need to add !empty($attendee['cutype']) to prevent from a warning in newer PHP versions. Also, Roundcube has in_array_nocase() function which we should just use here.


This will not gonna work when there's multiple resources (with the same owner) in the event.


The only difference is the body label argument, so instead of adding a whole if block I would just change the argument depending on the $resourceConfirmation state.


The foreach is redundant.


This if condition is not good enough for this purpose. And it assumes that the owner DN contains email address, I'm not sure this is always true with old Kolab.

This revision now requires changes to proceed.Dec 8 2021, 11:04 AM
mollekopf marked 4 inline comments as done.

Addressed comments


For the case of multiple resources we'll have to show individual RSVP buttons per matching attendee, that will be processed individually, so I think also in that case we can set _resource to the correct $attendee.

For the time being the entire codebase just does not deal with multiple matching attendees AFAIK, so nothing that I can reasonably fix in this patch I think.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Fixed owned resource lookup

Fixed owned resource lookup

This revision is now accepted and ready to land.Dec 17 2021, 1:07 PM
This revision was automatically updated to reflect the committed changes.