Page MenuHomekolab.org

Resource invitation enhancements
ClosedPublic

Authored by mollekopf on Dec 6 2021, 10:30 AM.

Details

Summary
  • Display RSVP buttons for resource owners.
  • Adapted mail texts to make sense for new resource invitations.
  • When generating a REPLY, keep track if we are responding on behalf of a resource, and set SENT-BY accordingly

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 37334
Build 14984: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Dec 6 2021, 10:30 AM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Dec 6 2021, 10:36 AM
machniak requested changes to this revision.Dec 8 2021, 11:04 AM
machniak added a subscriber: machniak.
machniak added inline comments.
plugins/calendar/calendar.php
1253

You need to add !empty($attendee['cutype']) to prevent from a warning in newer PHP versions. Also, Roundcube has in_array_nocase() function which we should just use here.

1256

This will not gonna work when there's multiple resources (with the same owner) in the event.

1266

The only difference is the body label argument, so instead of adding a whole if block I would just change the argument depending on the $resourceConfirmation state.

2018

The foreach is redundant.

2891

This if condition is not good enough for this purpose. And it assumes that the owner DN contains email address, I'm not sure this is always true with old Kolab.

This revision now requires changes to proceed.Dec 8 2021, 11:04 AM
mollekopf updated this revision to Diff 8855.Dec 16 2021, 3:27 PM
mollekopf marked 4 inline comments as done.

Addressed comments

mollekopf added inline comments.Dec 16 2021, 3:33 PM
plugins/calendar/calendar.php
1256

For the case of multiple resources we'll have to show individual RSVP buttons per matching attendee, that will be processed individually, so I think also in that case we can set _resource to the correct $attendee.

For the time being the entire codebase just does not deal with multiple matching attendees AFAIK, so nothing that I can reasonably fix in this patch I think.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.
mollekopf reopened this revision.Dec 17 2021, 12:29 PM
mollekopf updated this revision to Diff 8909.Dec 17 2021, 12:29 PM

Fixed owned resource lookup

mollekopf updated this revision to Diff 8912.Dec 17 2021, 12:30 PM

Fixed owned resource lookup

machniak accepted this revision.Dec 17 2021, 1:07 PM
This revision is now accepted and ready to land.Dec 17 2021, 1:07 PM
This revision was automatically updated to reflect the committed changes.