- Display RSVP buttons for resource owners.
- Adapted mail texts to make sense for new resource invitations.
- When generating a REPLY, keep track if we are responding on behalf of a resource, and set SENT-BY accordingly
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rRPK3613a3d39999: Resource invitation enhancements
rRPKa710a862db7e: Resource invitation enhancements
Diff Detail
- Repository
- rRPK roundcubemail-plugins-kolab
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 37334 Build 14984: arc lint + arc unit
Event Timeline
plugins/calendar/calendar.php | ||
---|---|---|
1253 | You need to add !empty($attendee['cutype']) to prevent from a warning in newer PHP versions. Also, Roundcube has in_array_nocase() function which we should just use here. | |
1256 | This will not gonna work when there's multiple resources (with the same owner) in the event. | |
1266 | The only difference is the body label argument, so instead of adding a whole if block I would just change the argument depending on the $resourceConfirmation state. | |
2018 | The foreach is redundant. | |
2891 | This if condition is not good enough for this purpose. And it assumes that the owner DN contains email address, I'm not sure this is always true with old Kolab. |
plugins/calendar/calendar.php | ||
---|---|---|
1256 | For the case of multiple resources we'll have to show individual RSVP buttons per matching attendee, that will be processed individually, so I think also in that case we can set _resource to the correct $attendee. For the time being the entire codebase just does not deal with multiple matching attendees AFAIK, so nothing that I can reasonably fix in this patch I think. |