Page MenuHomekolab.org

utils: activesynccli, kolabendpointtester, generatemail
ClosedPublic

Authored by mollekopf on Fri, Jan 7, 4:51 PM.

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Fri, Jan 7, 4:51 PM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Fri, Jan 7, 4:53 PM
mollekopf added a subscriber: Restricted Project.
machniak requested changes to this revision.Mon, Jan 10, 9:08 AM
machniak added a subscriber: machniak.
machniak added inline comments.
utils/activesynccli.py
9

Let's not give the test account credentials to everyone. Also, it's --username, not --user, and I'd put --password in a separate line.

385

This looks like out of place.

400

It's not only a directory.

403

"Device identifier"

409

Should be "--timezone", I guess.

utils/generatemail.py
2

The other two scripts use python3, it would be nice to be consistent. Also, scripts in extras/ directory use /usr/bin/python

83

The number should be an argument to the script.

utils/kolabendpointtester.py
7

It is --username. Or it is automatically recognized as --user too?

10

There's also --imap option.

This revision now requires changes to proceed.Mon, Jan 10, 9:08 AM
mollekopf updated this revision to Diff 9229.Mon, Jan 10, 12:22 PM
mollekopf marked 4 inline comments as done.

Script cleanup

mollekopf marked 5 inline comments as done.Mon, Jan 10, 12:23 PM
mollekopf added inline comments.
utils/activesynccli.py
409

No, it's a positional argument.

machniak accepted this revision.Tue, Jan 11, 9:57 AM
This revision is now accepted and ready to land.Tue, Jan 11, 9:57 AM
This revision was automatically updated to reflect the committed changes.