Paths

Table of Contentst

Differential D3211

utils: activesynccli, kolabendpointtester, generatemail
ClosedPublic
Actions

Authored by mollekopf on Jan 7 2022, 4:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 13, 12:51 PM

	Unknown Object (File)
	Sat, Apr 13, 12:26 PM

	Unknown Object (File)
	Tue, Apr 9, 3:20 PM

	Unknown Object (File)
	Feb 25 2024, 12:35 AM

	Unknown Object (File)
	Feb 10 2024, 6:49 AM

	Unknown Object (File)
	Feb 8 2024, 6:43 PM

	Unknown Object (File)
	Jan 24 2024, 2:17 PM

	Unknown Object (File)
	Jan 24 2024, 2:13 PM

View All 23 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK9f64703aff04: utils: activesynccli, kolabendpointtester, generatemail
rKdff0dad77ec1: utils: activesynccli, kolabendpointtester, generatemail
rK101f7fba0926: utils: activesynccli, kolabendpointtester, generatemail

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jan 7 2022, 4:51 PM

mollekopf created this revision.

Harbormaster completed remote builds in B37738: Diff 9172.Jan 7 2022, 4:51 PM

mollekopf added a reviewer: Restricted Project.Jan 7 2022, 4:53 PM

mollekopf added a subscriber: Restricted Project.

machniak requested changes to this revision.Jan 10 2022, 9:08 AM

machniak subscribed.

machniak added inline comments.

utils/activesynccli.py
9	Let's not give the test account credentials to everyone. Also, it's --username, not --user, and I'd put --password in a separate line.
385	This looks like out of place.
400	It's not only a directory.
403	"Device identifier"
409	Should be "--timezone", I guess.
utils/generatemail.py
2	The other two scripts use python3, it would be nice to be consistent. Also, scripts in extras/ directory use `/usr/bin/python`
83	The number should be an argument to the script.
utils/kolabendpointtester.py
7	It is --username. Or it is automatically recognized as --user too?
10	There's also --imap option.

This revision now requires changes to proceed.Jan 10 2022, 9:08 AM

Script cleanup

Harbormaster completed remote builds in B37813: Diff 9229.Jan 10 2022, 12:22 PM

mollekopf marked 5 inline comments as done.Jan 10 2022, 12:23 PM

mollekopf added inline comments.

utils/activesynccli.py
409	No, it's a positional argument.

machniak accepted this revision.Jan 11 2022, 9:57 AM

This revision is now accepted and ready to land.Jan 11 2022, 9:57 AM

Closed by commit rK9f64703aff04: utils: activesynccli, kolabendpointtester, generatemail (authored by mollekopf). · Explain WhyJan 11 2022, 7:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

utils/

activesynccli.py

344 lines

generatemail.py

97 lines

kolabendpointtester.py

452 lines

Diff 9274

utils/activesynccli.py

Loading...

utils/generatemail.py

Loading...

utils/kolabendpointtester.py

Loading...