Page MenuHomePhorge

utils: activesynccli, kolabendpointtester, generatemail
ClosedPublic

Authored by mollekopf on Jan 7 2022, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 25 2024, 12:35 AM
Unknown Object (File)
Feb 10 2024, 6:49 AM
Unknown Object (File)
Feb 8 2024, 6:43 PM
Unknown Object (File)
Jan 24 2024, 2:17 PM
Unknown Object (File)
Jan 24 2024, 2:13 PM
Unknown Object (File)
Jan 24 2024, 6:40 AM
Unknown Object (File)
Jan 21 2024, 10:49 AM
Unknown Object (File)
Dec 21 2023, 11:23 AM
Subscribers
Restricted Project

Diff Detail

Repository
rK kolab
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37738
Build 15202: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Jan 7 2022, 4:53 PM
mollekopf added a subscriber: Restricted Project.
machniak subscribed.
machniak added inline comments.
utils/activesynccli.py
8

Let's not give the test account credentials to everyone. Also, it's --username, not --user, and I'd put --password in a separate line.

384

This looks like out of place.

399

It's not only a directory.

402

"Device identifier"

408

Should be "--timezone", I guess.

utils/generatemail.py
1

The other two scripts use python3, it would be nice to be consistent. Also, scripts in extras/ directory use /usr/bin/python

82

The number should be an argument to the script.

utils/kolabendpointtester.py
6

It is --username. Or it is automatically recognized as --user too?

9

There's also --imap option.

This revision now requires changes to proceed.Jan 10 2022, 9:08 AM
mollekopf marked 4 inline comments as done.

Script cleanup

mollekopf added inline comments.
utils/activesynccli.py
408

No, it's a positional argument.

This revision is now accepted and ready to land.Jan 11 2022, 9:57 AM
This revision was automatically updated to reflect the committed changes.