utils: activesynccli, kolabendpointtester, generatemail
ClosedPublic
Actions

Authored by mollekopf on Jan 7 2022, 3:51 PM.

Project Tags

None

Referenced Files

	F117764587: D3211.1775227886.diff
	Thu, Apr 2, 2:51 PM

	F117751732: D3211.1775186652.diff
	Thu, Apr 2, 3:24 AM

Subscribers

Restricted Project

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

mollekopf requested review of this revision.Jan 7 2022, 3:51 PM

mollekopf created this revision.

mollekopf added a reviewer: Restricted Project.Jan 7 2022, 3:53 PM

mollekopf added a subscriber: Restricted Project.

machniak requested changes to this revision.Jan 10 2022, 8:08 AM

machniak subscribed.

machniak added inline comments.

utils/activesynccli.py
9	Let's not give the test account credentials to everyone. Also, it's --username, not --user, and I'd put --password in a separate line.
385	This looks like out of place.
400	It's not only a directory.
403	"Device identifier"
409	Should be "--timezone", I guess.
utils/generatemail.py
2	The other two scripts use python3, it would be nice to be consistent. Also, scripts in extras/ directory use `/usr/bin/python`
83	The number should be an argument to the script.
utils/kolabendpointtester.py
7	It is --username. Or it is automatically recognized as --user too?
10	There's also --imap option.