Page MenuHomePhorge

utils: activesynccli, kolabendpointtester, generatemail
ClosedPublic

Authored by mollekopf on Jan 7 2022, 4:51 PM.
Tags
None
Referenced Files
F12051189: D3211.id9274.diff
Tue, May 7, 5:57 PM
F12051186: D3211.id9172.diff
Tue, May 7, 5:56 PM
F12051183: D3211.id9229.diff
Tue, May 7, 5:56 PM
F12051180: D3211.id.diff
Tue, May 7, 5:56 PM
Unknown Object (File)
Mon, May 6, 4:34 PM
Unknown Object (File)
Sat, May 4, 5:39 PM
Unknown Object (File)
Wed, May 1, 8:52 AM
Unknown Object (File)
Tue, Apr 30, 5:27 PM
Subscribers
Restricted Project

Diff Detail

Repository
rK kolab
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37813
Build 15253: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Jan 7 2022, 4:53 PM
mollekopf added a subscriber: Restricted Project.
machniak subscribed.
machniak added inline comments.
utils/activesynccli.py
9

Let's not give the test account credentials to everyone. Also, it's --username, not --user, and I'd put --password in a separate line.

385

This looks like out of place.

400

It's not only a directory.

403

"Device identifier"

409

Should be "--timezone", I guess.

utils/generatemail.py
2

The other two scripts use python3, it would be nice to be consistent. Also, scripts in extras/ directory use /usr/bin/python

83

The number should be an argument to the script.

utils/kolabendpointtester.py
7

It is --username. Or it is automatically recognized as --user too?

10

There's also --imap option.

This revision now requires changes to proceed.Jan 10 2022, 9:08 AM
mollekopf marked 4 inline comments as done.

Script cleanup

mollekopf added inline comments.
utils/activesynccli.py
409

No, it's a positional argument.

This revision is now accepted and ready to land.Jan 11 2022, 9:57 AM
This revision was automatically updated to reflect the committed changes.