Page MenuHomekolab.org

Shared folders
ClosedPublic

Authored by machniak on Dec 3 2021, 9:55 AM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKa7cd372f8179: Shared folders
rK9da1d8fde793: Shared folders
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Dec 3 2021, 9:55 AM
machniak created this revision.
machniak updated this revision to Diff 8759.Dec 3 2021, 12:36 PM
  • Fix regression
  • Complete imap tests
  • Cleanup and more tests
machniak updated this revision to Diff 8765.Dec 3 2021, 2:51 PM
  • Re-title shared_folders SKU to shared-folders for consistency with others
  • Make phpstan happy
  • Make phpstan happy, now we're green
machniak updated this revision to Diff 8819.Dec 10 2021, 1:55 PM
  • Add tests for resource's jobs
  • Add tests for shared folders' jobs
mollekopf accepted this revision.Dec 17 2021, 9:34 AM
mollekopf added a subscriber: mollekopf.

Looks good aside from the non-blocking comments.

src/app/Http/Controllers/API/V4/PaymentsController.php
170

This doesn't belong in this patch I think.

src/app/SharedFolder.php
1

Perhaps a Resource should become a SharedFolder (via inheritance directly, or perhaps via a baseclass to avoid including the wrong traits),? Otherwise we just duplicate code.

This revision is now accepted and ready to land.Dec 17 2021, 9:34 AM

From manual testing it seems to me that a new shared folder never makes it out of the "Not Ready" state.
The controller is repeatedly queried for a status update, but the code never checks back in imap/ldap after initially failing on a GETMETADATA command (when creating the folder).

The only way to get it active is to wait for a Refresh button to appear (after a pretty long timeout), pressing it immediately turns it to active.

Could be that it fixes itself when waiting for longer, but from a UX perspective it's not ideal (but perhaps just a later enhancement).

This revision was automatically updated to reflect the committed changes.