Page MenuHomePhorge

Shared folders
ClosedPublic

Authored by machniak on Dec 3 2021, 9:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 4:00 PM
Unknown Object (File)
Feb 21 2024, 8:18 PM
Unknown Object (File)
Feb 19 2024, 7:40 PM
Unknown Object (File)
Feb 19 2024, 1:24 PM
Unknown Object (File)
Feb 15 2024, 8:28 PM
Unknown Object (File)
Feb 9 2024, 5:49 AM
Unknown Object (File)
Feb 9 2024, 5:48 AM
Unknown Object (File)
Feb 8 2024, 6:37 AM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKa7cd372f8179: Shared folders
rK9da1d8fde793: Shared folders
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/shared-folders
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37244
Build 14894: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Fix regression
  • Complete imap tests
  • Cleanup and more tests
  • Re-title shared_folders SKU to shared-folders for consistency with others
  • Make phpstan happy
  • Make phpstan happy, now we're green
  • Add tests for resource's jobs
  • Add tests for shared folders' jobs
mollekopf subscribed.

Looks good aside from the non-blocking comments.

src/app/Http/Controllers/API/V4/PaymentsController.php
170 ↗(On Diff #8819)

This doesn't belong in this patch I think.

src/app/SharedFolder.php
1

Perhaps a Resource should become a SharedFolder (via inheritance directly, or perhaps via a baseclass to avoid including the wrong traits),? Otherwise we just duplicate code.

This revision is now accepted and ready to land.Dec 17 2021, 9:34 AM

From manual testing it seems to me that a new shared folder never makes it out of the "Not Ready" state.
The controller is repeatedly queried for a status update, but the code never checks back in imap/ldap after initially failing on a GETMETADATA command (when creating the folder).

The only way to get it active is to wait for a Refresh button to appear (after a pretty long timeout), pressing it immediately turns it to active.

Could be that it fixes itself when waiting for longer, but from a UX perspective it's not ideal (but perhaps just a later enhancement).

This revision was automatically updated to reflect the committed changes.