Page MenuHomekolab.org

Implement ACT_STORE_AND_NOTIFY policy for resources, add webmail url to the notification body
ClosedPublic

Authored by mollekopf on Dec 4 2021, 10:48 PM.

Details

Summary

Set the status to NEEDS_ACTION and don't send out an immediate reply to
the organizer.

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Dec 4 2021, 10:48 PM
mollekopf created this revision.
mollekopf added reviewers: Restricted Project, PyKolab Developers.Dec 4 2021, 10:49 PM
machniak requested changes to this revision.Dec 8 2021, 10:37 AM
machniak added a subscriber: machniak.
# nosetests tests/unit/test-011-wallace_resources.py
.....E
======================================================================
ERROR: test_007_accept_reservation_request_store_and_notify
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/utils.py", line 191, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/root/kolab-pykolab/tests/unit/test-011-wallace_resources.py", line 274, in test_007_accept_reservation_request_store_and_notify
    self.assertEqual("resource-collection-car@example.org", self.smtplog[1][0])
IndexError: list index out of range

it should be self.smtplog[0]0] in line 274 and self.smtplog[0][1] in line 276.

This revision now requires changes to proceed.Dec 8 2021, 10:37 AM
mollekopf updated this revision to Diff 8849.Dec 16 2021, 1:56 PM

addressed comment, but I unfortunately still can't run the nosetests

machniak accepted this revision.Dec 16 2021, 2:00 PM
This revision is now accepted and ready to land.Dec 16 2021, 2:00 PM
This revision was landed with ongoing or failed builds.Dec 16 2021, 3:41 PM
This revision was automatically updated to reflect the committed changes.